You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by bhavya411 <gi...@git.apache.org> on 2018/03/29 15:07:22 UTC
[GitHub] carbondata pull request #2114: [CARBONDATA-2295] Added property for UnsafeMe...
GitHub user bhavya411 opened a pull request:
https://github.com/apache/carbondata/pull/2114
[CARBONDATA-2295] Added property for UnsafeMemory configuration
Added property for setting up the unsafe memory limit in MB
- [ X] Testing done
Added a new property in the test cases to make sure they all run fine
Tested manually on the presto client as well
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bhavya411/incubator-carbondata CARBONDATA-2295
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2114.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2114
----
commit 9e44537b97340e71829f733d878e1dfab8affbdc
Author: Bhavya <bh...@...>
Date: 2018-03-29T15:03:34Z
Added property for UnsafeMemory configuration
----
---
[GitHub] carbondata issue #2114: [CARBONDATA-2295] Added property for UnsafeMemory co...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2114
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4680/
---
[GitHub] carbondata pull request #2114: [CARBONDATA-2295] Added property for UnsafeMe...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2114#discussion_r178229105
--- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/impl/CarbonTableReader.java ---
@@ -366,7 +368,10 @@ public TBase create() {
public List<CarbonLocalInputSplit> getInputSplits2(CarbonTableCacheModel tableCacheModel,
Expression filters) {
List<CarbonLocalInputSplit> result = new ArrayList<>();
-
+ if(config.getUnsafeMemoryInMb() != null) {
+ CarbonProperties.getInstance().addProperty(CarbonCommonConstants.UNSAFE_WORKING_MEMORY_IN_MB,
--- End diff --
please add this configuration description to presto/README.md
---
[GitHub] carbondata pull request #2114: [CARBONDATA-2295] Added property for UnsafeMe...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2114
---
[GitHub] carbondata issue #2114: [CARBONDATA-2295] Added property for UnsafeMemory co...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2114
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3453/
---
[GitHub] carbondata issue #2114: [CARBONDATA-2295] Added property for UnsafeMemory co...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2114
LGTM
---
[GitHub] carbondata issue #2114: [CARBONDATA-2295] Added property for UnsafeMemory co...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2114
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4668/
---
[GitHub] carbondata issue #2114: [CARBONDATA-2295] Added property for UnsafeMemory co...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2114
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4189/
---
[GitHub] carbondata pull request #2114: [CARBONDATA-2295] Added property for UnsafeMe...
Posted by bhavya411 <gi...@git.apache.org>.
Github user bhavya411 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2114#discussion_r178230596
--- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/impl/CarbonTableReader.java ---
@@ -366,7 +368,10 @@ public TBase create() {
public List<CarbonLocalInputSplit> getInputSplits2(CarbonTableCacheModel tableCacheModel,
Expression filters) {
List<CarbonLocalInputSplit> result = new ArrayList<>();
-
+ if(config.getUnsafeMemoryInMb() != null) {
+ CarbonProperties.getInstance().addProperty(CarbonCommonConstants.UNSAFE_WORKING_MEMORY_IN_MB,
--- End diff --
Done
---
[GitHub] carbondata issue #2114: [CARBONDATA-2295] Added property for UnsafeMemory co...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2114
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4180/
---
[GitHub] carbondata issue #2114: [CARBONDATA-2295] Added property for UnsafeMemory co...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2114
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3442/
---