You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "David Smiley (Jira)" <ji...@apache.org> on 2020/03/30 13:51:00 UTC
[jira] [Commented] (SOLR-10182) Backout directory metrics
collection that caused performance degradation
[ https://issues.apache.org/jira/browse/SOLR-10182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17070981#comment-17070981 ]
David Smiley commented on SOLR-10182:
-------------------------------------
Just an observation as I stumble over the code: I see that the metrics was removed from loadDirectoryFactory()'s method but this method signature *still* takes an unused "registryName". I think it should be removed. Even if someone wanted to create a custom DirectoryFactory that used the metrics registry, the name of the registry could/should be looked up from some other thing (ultimately a ThreadLocal somewhere), similar to how we handle MDC logging & SolrRequestInfo.
> Backout directory metrics collection that caused performance degradation
> ------------------------------------------------------------------------
>
> Key: SOLR-10182
> URL: https://issues.apache.org/jira/browse/SOLR-10182
> Project: Solr
> Issue Type: Task
> Components: metrics
> Affects Versions: 6.4, 6.4.1
> Reporter: Ishan Chattopadhyaya
> Assignee: Andrzej Bialecki
> Priority: Blocker
> Fix For: 6.4.2, 6.5, 7.0
>
> Attachments: SOLR-10182.patch
>
>
> The performance degradation we observed as per SOLR-10130 will go away if directory factory level metrics collection is disabled by default. However, since they will cause the same degradation when enabled, we should back out those changes until we find a performant way of implementing such metrics collection.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org