Re: [PR] LANG-1172: Support dash as a delimiter in locales [commons-lang]

["seadbrane (via GitHub)" <gi...@apache.org>]

seadbrane commented on PR #766:
URL: https://github.com/apache/commons-lang/pull/766#issuecomment-1912667376

   This change has resulted in some broken expectations in the differences between locale and language tags.  While there is probably value in having a method that is open to taking either in order to produce a Locale object, it is not clear that should be this method.  In fact, the original and current comments for the method say "This method takes the **string format of a locale** and creates the locale object from it".   In addition, the rationale for why this specific change was made appears to based on some inaccurate understanding - BCP 47 is the spec for language tags, not locales and BCP47 does not support 'underscore', which was this method only supported before this change.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org