[jira] [Commented] (KAFKA-3827) log.message.format.version should default to inter.broker.protocol.version

["Edoardo Comar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-3827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15370562#comment-15370562 ] 

Edoardo Comar commented on KAFKA-3827:
--------------------------------------

Hu [~junrao] [~ijuma] [~ewencp]
given that the upgrade docs at 
https://kafka.apache.org/documentation.html#upgrade cannot be relied on, because of this issue,
one MUST also set log.message.format.version=0.9 if they set inter.broker.protocol.version=0.9

two questions:
1) if one sets the two properties and does a rolling 0.9->0.10 upgrade, 
is the second step of the upgrade to remove both settings (ie have them both =0.10) in one go 
or
then the settings should be removed one at a time and restarting each time ?


2) what is the actual disadvantage in NOT setting inter.broker.protocol.version=0.9 (and log.message.format.version)
and doing the 0.9->0.10 rolling upgrade anyway ? 

I would guess that the brokers still running on 0.9 won't understand replication from brokers already on 0.10 ?
But if  a short outage is tolerated and all the brokers are quickly brought back to 0.10 this would be ok, wouldn't it ?

thanks! 


> log.message.format.version should default to inter.broker.protocol.version
> --------------------------------------------------------------------------
>
>                 Key: KAFKA-3827
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3827
>             Project: Kafka
>          Issue Type: Improvement
>    Affects Versions: 0.10.0.0
>            Reporter: Jun Rao
>            Assignee: Manasvi Gupta
>              Labels: newbie
>
> Currently, if one sets inter.broker.protocol.version to 0.9.0 and restarts the broker, one will get the following exception since log.message.format.version defaults to 0.10.0. It will be more intuitive if log.message.format.version defaults to the value of inter.broker.protocol.version.
> java.lang.IllegalArgumentException: requirement failed: log.message.format.version 0.10.0-IV1 cannot be used when inter.broker.protocol.version is set to 0.9.0.1
> 	at scala.Predef$.require(Predef.scala:233)
> 	at kafka.server.KafkaConfig.validateValues(KafkaConfig.scala:1023)
> 	at kafka.server.KafkaConfig.<init>(KafkaConfig.scala:994)
> 	at kafka.server.KafkaConfig$.fromProps(KafkaConfig.scala:743)
> 	at kafka.server.KafkaConfig$.fromProps(KafkaConfig.scala:740)
> 	at kafka.server.KafkaServerStartable$.fromProps(KafkaServerStartable.scala:28)
> 	at kafka.Kafka$.main(Kafka.scala:58)
> 	at kafka.Kafka.main(Kafka.scala)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)