You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/05/20 03:55:47 UTC

[GitHub] [helix] pkuwm opened a new pull request #1023: Fix conflicting MonitorDomainNames in metrics-common and helix-core

pkuwm opened a new pull request #1023:
URL: https://github.com/apache/helix/pull/1023


   ### Issues
   
   - [ ] My PR addresses the following Helix issues and references them in the PR description:
   
   Fixes #1022 
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   
   We realized that there are two MonitorDomainNames classes in modules: helix-core and metrics-common. The one in metrics-common is old and missing a field Rebalancer. This would cause RuntimeException error and failure for customers' running if the old class is being used in runtime: `java.lang.NoSuchFieldError: Rebalancer`
   
   This PR updates the class MonitorDomainNames in metrics-common and removes the duplicate one in helix-core.
   
   ### Tests
   
   - [ ] The following tests are written for this issue:
   
   NA
   
   - [ ] The following is the result of the "mvn test" command on the appropriate module:
   
   Running
   
   ### Commits
   
   - [ ] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation (Optional)
   
   - [ ] In case of new functionality, my PR adds documentation in the following wiki page:
   
   (Link the GitHub wiki you added)
   
   ### Code Quality
   
   - [ ] My diff has been formatted using helix-style.xml 
   (helix-style-intellij.xml if IntelliJ IDE is used)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] jiajunwang commented on a change in pull request #1023: Fix conflicting MonitorDomainNames in metrics-common and helix-core

Posted by GitBox <gi...@apache.org>.
jiajunwang commented on a change in pull request #1023:
URL: https://github.com/apache/helix/pull/1023#discussion_r427759666



##########
File path: helix-core/src/main/java/org/apache/helix/monitoring/mbeans/MonitorDomainNames.java
##########
@@ -1,33 +0,0 @@
-package org.apache.helix.monitoring.mbeans;
-
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-/**
- * This enum defines all of domain names used with various Helix monitor mbeans.
- */
-public enum MonitorDomainNames {

Review comment:
       Is this a backward compatibility violation?
   
   I think we need a more complete solution to ensure backward compatibility, or we just finish the full migration.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] jiajunwang commented on a change in pull request #1023: Fix conflicting MonitorDomainNames in metrics-common and helix-core

Posted by GitBox <gi...@apache.org>.
jiajunwang commented on a change in pull request #1023:
URL: https://github.com/apache/helix/pull/1023#discussion_r428216853



##########
File path: helix-core/src/main/java/org/apache/helix/monitoring/mbeans/MonitorDomainNames.java
##########
@@ -1,33 +0,0 @@
-package org.apache.helix.monitoring.mbeans;
-
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-/**
- * This enum defines all of domain names used with various Helix monitor mbeans.
- */
-public enum MonitorDomainNames {

Review comment:
       You are right. I missed the package path.
   Since they are the same, it would be fine.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] pkuwm commented on a change in pull request #1023: Fix conflicting MonitorDomainNames in metrics-common and helix-core

Posted by GitBox <gi...@apache.org>.
pkuwm commented on a change in pull request #1023:
URL: https://github.com/apache/helix/pull/1023#discussion_r427767306



##########
File path: helix-core/src/main/java/org/apache/helix/monitoring/mbeans/MonitorDomainNames.java
##########
@@ -1,33 +0,0 @@
-package org.apache.helix.monitoring.mbeans;
-
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-/**
- * This enum defines all of domain names used with various Helix monitor mbeans.
- */
-public enum MonitorDomainNames {

Review comment:
       The key point is, both classes are packaged in `org.apache.helix.monitoring.mbeans`, so I think it is backward compatible. Although this class is public, client's code doesn't have to change the import. Helix-core.jar depends on helix-common.jar and metrics-common.jar, so it is OK to remove this class in helix-core, as long as we have it in the same package.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] jiajunwang merged pull request #1023: Fix conflicting MonitorDomainNames in metrics-common and helix-core

Posted by GitBox <gi...@apache.org>.
jiajunwang merged pull request #1023:
URL: https://github.com/apache/helix/pull/1023


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] pkuwm commented on pull request #1023: Fix conflicting MonitorDomainNames in metrics-common and helix-core

Posted by GitBox <gi...@apache.org>.
pkuwm commented on pull request #1023:
URL: https://github.com/apache/helix/pull/1023#issuecomment-632946096


   This PR is ready to be merged, approved by @jiajunwang @narendly 
   
   Commit message
   ```
   There are two MonitorDomainNames classes in modules: helix-core and metrics-common. The one in metrics-common misses a field Rebalancer and would cause RuntimeException error and failure for customers' running if the old class is being used in runtime: java.lang.NoSuchFieldError: Rebalancer.
   
   This commit fixes this issue by updating the class MonitorDomainNames in metrics-common and removing the duplicate one in helix-core
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org