[GitHub] [beam] damondouglas commented on a change in pull request #15656: [BEAM-12983] [Playground] Initial gRPC server

[GitBox <gi...@apache.org>]

damondouglas commented on a change in pull request #15656:
URL: https://github.com/apache/beam/pull/15656#discussion_r727243200



##########
File path: playground/backend/cmd/server/wrapper.go
##########
@@ -0,0 +1,39 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements.  See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+//
+//    http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package main
+
+import (
+	"github.com/improbable-eng/grpc-web/go/grpcweb"
+	"github.com/rs/cors"
+	"google.golang.org/grpc"
+	"net/http"
+)
+
+// Wrap a grpc.Server as a http.Handler
+func Wrap(svc *grpc.Server, options []grpcweb.Option) http.Handler {
+	wrappedServer := grpcweb.WrapServer(svc, options...)
+	cors.AllowAll().Handler(&wrapper{

Review comment:
       For a future PR we should address what is the minimum necessary.

##########
File path: playground/backend/cmd/server/server.go
##########
@@ -16,9 +16,57 @@
 package main
 
 import (
-	"beam.apache.org/playground/backend/internal/executors"
+	pb "beam.apache.org/playground/backend/internal/api"
+	"beam.apache.org/playground/backend/internal/environment"

Review comment:
       Is this PR serving as a placeholder or do we need to include the environment library as part of this PR?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org