You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/12/31 10:01:58 UTC

[GitHub] [druid] clintropolis opened a new pull request #9112: null handling for doubles sketch and array of doubles sketch aggs

clintropolis opened a new pull request #9112: null handling for doubles sketch and array of doubles sketch aggs
URL: https://github.com/apache/druid/pull/9112
 
 
   ### Description
   
   Similar to #9073 and #9075, this PR modifies doubles sketch and array of doubles sketch aggregators to ignore null valued rows when SQL compatible null handling mode is enabled.
   
   Note that it is still possible to treat `null` valued rows as `0` in SQL compatible null handling mode _if desired by the user_, through using virtual columns with `nvl`, as illustrated in one of the added tests.
   
   <hr>
   
   This PR has:
   - [x] been self-reviewed.
   - [x] added unit tests or modified existing tests to cover new code paths.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] jon-wei merged pull request #9112: null handling for doubles sketch and array of doubles sketch aggs

Posted by GitBox <gi...@apache.org>.
jon-wei merged pull request #9112: null handling for doubles sketch and array of doubles sketch aggs
URL: https://github.com/apache/druid/pull/9112
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org