You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/09 19:37:53 UTC

[GitHub] [arrow-datafusion] alamb opened a new pull request #1801: Fix logical conflict

alamb opened a new pull request #1801:
URL: https://github.com/apache/arrow-datafusion/pull/1801


   Fix logical conflict between 1bedaf33986ea01d78d21cf1878da40497b1b828 (https://github.com/apache/arrow-datafusion/commit/1bedaf33986ea01d78d21cf1878da40497b1b828) which added a new example `ExecutionPlan` and  071f14ade65b7e491898c06e7b086282cf12a442 (https://github.com/apache/arrow-datafusion/pull/1776) that added a new required trait method for `ExecutionPlan` 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-datafusion] alamb merged pull request #1801: Fix logical conflict

Posted by GitBox <gi...@apache.org>.
alamb merged pull request #1801:
URL: https://github.com/apache/arrow-datafusion/pull/1801


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-datafusion] matthewmturner commented on pull request #1801: Fix logical conflict

Posted by GitBox <gi...@apache.org>.
matthewmturner commented on pull request #1801:
URL: https://github.com/apache/arrow-datafusion/pull/1801#issuecomment-1034125339


   thx @alamb. I was getting very confused lol


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-datafusion] alamb commented on pull request #1801: Fix logical conflict

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1801:
URL: https://github.com/apache/arrow-datafusion/pull/1801#issuecomment-1034124409


   cc @thinkharderdev @matthewmturner 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-datafusion] alamb commented on pull request #1801: Fix logical conflict

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1801:
URL: https://github.com/apache/arrow-datafusion/pull/1801#issuecomment-1034164799


   @realno  I think it is because two different PRs passed the CI checks individually but together they broke things


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-datafusion] realno commented on pull request #1801: Fix logical conflict

Posted by GitBox <gi...@apache.org>.
realno commented on pull request #1801:
URL: https://github.com/apache/arrow-datafusion/pull/1801#issuecomment-1034162100


   This actually breaks the build (at least on m1 mac), not sure how it wasn't captured by the pipeline 🤔 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org