You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/08/16 14:04:55 UTC

[GitHub] [rocketmq-flink] yiduwangkai commented on a diff in pull request #46: [ISSUE #35]Use litePullConsumer model instead of default p…

yiduwangkai commented on code in PR #46:
URL: https://github.com/apache/rocketmq-flink/pull/46#discussion_r946821892


##########
src/main/java/org/apache/rocketmq/flink/legacy/RocketMQSourceFunction.java:
##########
@@ -241,91 +243,58 @@ public void run(SourceContext context) throws Exception {
                                     () -> {
                                         while (runningChecker.isRunning()) {
                                             try {
-                                                long offset = getMessageQueueOffset(mq);
-
-                                                PullResult pullResult = null;
+                                                getMessageQueueOffset(mq);
                                                 if (StringUtils.isEmpty(sql)) {
-                                                    pullResult =
-                                                            consumer.pullBlockIfNotFound(
-                                                                    mq, tag, offset, pullBatchSize);
+                                                    consumer.subscribe(topic, tag);

Review Comment:
   ok



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org