You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/02/27 13:15:38 UTC
[GitHub] [servicecomb-service-center] ChinX opened a new pull request #637:
[SCB-1790] [Syncer] Simplify serf module code and optimize dependencies
ChinX opened a new pull request #637: [SCB-1790] [Syncer] Simplify serf module code and optimize dependencies
URL: https://github.com/apache/servicecomb-service-center/pull/637
Base on PR #636
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-service-center] zenlint merged pull request #637:
[SCB-1790] [Syncer] Simplify serf module code and optimize dependencies
Posted by GitBox <gi...@apache.org>.
zenlint merged pull request #637: [SCB-1790] [Syncer] Simplify serf module code and optimize dependencies
URL: https://github.com/apache/servicecomb-service-center/pull/637
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-service-center] coveralls commented on issue #637:
[SCB-1790] [Syncer] Simplify serf module code and optimize dependencies
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #637: [SCB-1790] [Syncer] Simplify serf module code and optimize dependencies
URL: https://github.com/apache/servicecomb-service-center/pull/637#issuecomment-591973135
[](https://coveralls.io/builds/28998303)
Coverage increased (+1.4%) to 61.084% when pulling **a926e0f10dfc9ccaa0ec5998ed585be907881e9f on ChinX:syncer-serf** into **ab4ec2eef3ffe6a24a55e833792520cbf05cc322 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-service-center] codecov-io commented on issue #637:
[SCB-1790] [Syncer] Simplify serf module code and optimize dependencies
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #637: [SCB-1790] [Syncer] Simplify serf module code and optimize dependencies
URL: https://github.com/apache/servicecomb-service-center/pull/637#issuecomment-591974195
# [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/637?src=pr&el=h1) Report
> Merging [#637](https://codecov.io/gh/apache/servicecomb-service-center/pull/637?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/85dc71bdc30cb3a226170b99c98e8e3df6cc5c78?src=pr&el=desc) will **increase** coverage by `1.51%`.
> The diff coverage is `88.4%`.
[](https://codecov.io/gh/apache/servicecomb-service-center/pull/637?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #637 +/- ##
==========================================
+ Coverage 57.12% 58.63% +1.51%
==========================================
Files 207 216 +9
Lines 16062 16393 +331
==========================================
+ Hits 9175 9612 +437
+ Misses 6220 6112 -108
- Partials 667 669 +2
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/637?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [syncer/task/idle/idle.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/637/diff?src=pr&el=tree#diff-c3luY2VyL3Rhc2svaWRsZS9pZGxlLmdv) | `100% <100%> (ø)` | |
| [syncer/pkg/utils/atomic\_bool.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/637/diff?src=pr&el=tree#diff-c3luY2VyL3BrZy91dGlscy9hdG9taWNfYm9vbC5nbw==) | `100% <100%> (ø)` | |
| [syncer/task/task.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/637/diff?src=pr&el=tree#diff-c3luY2VyL3Rhc2svdGFzay5nbw==) | `100% <100%> (ø)` | |
| [syncer/serf/option.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/637/diff?src=pr&el=tree#diff-c3luY2VyL3NlcmYvb3B0aW9uLmdv) | `100% <100%> (ø)` | |
| [syncer/task/ticker/ticker.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/637/diff?src=pr&el=tree#diff-c3luY2VyL3Rhc2svdGlja2VyL3RpY2tlci5nbw==) | `100% <100%> (ø)` | |
| [syncer/serf/handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/637/diff?src=pr&el=tree#diff-c3luY2VyL3NlcmYvaGFuZGxlci5nbw==) | `100% <100%> (ø)` | |
| [syncer/serf/query.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/637/diff?src=pr&el=tree#diff-c3luY2VyL3NlcmYvcXVlcnkuZ28=) | `100% <100%> (ø)` | |
| [syncer/pkg/utils/addr.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/637/diff?src=pr&el=tree#diff-c3luY2VyL3BrZy91dGlscy9hZGRyLmdv) | `56.25% <57.14%> (-7.39%)` | :arrow_down: |
| [syncer/etcd/etcd.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/637/diff?src=pr&el=tree#diff-c3luY2VyL2V0Y2QvZXRjZC5nbw==) | `75.92% <75.92%> (ø)` | |
| [syncer/config/verify.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/637/diff?src=pr&el=tree#diff-c3luY2VyL2NvbmZpZy92ZXJpZnkuZ28=) | `81.9% <81.9%> (ø)` | |
| ... and [27 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/637/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/637?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/637?src=pr&el=footer). Last update [85dc71b...a926e0f](https://codecov.io/gh/apache/servicecomb-service-center/pull/637?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-service-center] zenlint commented on issue #637:
[SCB-1790] [Syncer] Simplify serf module code and optimize dependencies
Posted by GitBox <gi...@apache.org>.
zenlint commented on issue #637: [SCB-1790] [Syncer] Simplify serf module code and optimize dependencies
URL: https://github.com/apache/servicecomb-service-center/pull/637#issuecomment-604793588
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services