You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2019/03/06 05:10:39 UTC
Review Request 70135: Improved isolation for slave tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70135/
-----------------------------------------------------------
Review request for mesos, Gilbert Song and Jie Yu.
Repository: mesos
Description
-------
Improved isolation of the `SlaveTest` fixture so it won't pick up
"orphaned" containers when running as root.
Diffs
-----
src/tests/slave_tests.cpp 22a0295086ae4f4ec26df00a0e077eecfa27f1fb
Diff: https://reviews.apache.org/r/70135/diff/1/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 70135: Improved isolation for slave tests.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70135/#review213463
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On March 5, 2019, 9:49 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70135/
> -----------------------------------------------------------
>
> (Updated March 5, 2019, 9:49 p.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improved isolation of the `SlaveTest` fixture so it won't pick up
> containers from another running Mesos instance on the same host when
> running as root.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 22a0295086ae4f4ec26df00a0e077eecfa27f1fb
>
>
> Diff: https://reviews.apache.org/r/70135/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70135: Improved isolation for slave tests.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70135/
-----------------------------------------------------------
(Updated March 6, 2019, 5:49 a.m.)
Review request for mesos, Gilbert Song and Jie Yu.
Repository: mesos
Description (updated)
-------
Improved isolation of the `SlaveTest` fixture so it won't pick up
containers from another running Mesos instance on the same host when
running as root.
Diffs
-----
src/tests/slave_tests.cpp 22a0295086ae4f4ec26df00a0e077eecfa27f1fb
Diff: https://reviews.apache.org/r/70135/diff/1/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 70135: Improved isolation for slave tests.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
> On March 6, 2019, 5:13 a.m., Gilbert Song wrote:
> > Why does it related to orphan containers?
If another Mesos instance is running on the host, it would get container ids from the `/mesos` cgroup and treated them as "orphaned."
- Chun-Hung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70135/#review213459
-----------------------------------------------------------
On March 6, 2019, 5:10 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70135/
> -----------------------------------------------------------
>
> (Updated March 6, 2019, 5:10 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improved isolation of the `SlaveTest` fixture so it won't pick up
> "orphaned" containers when running as root.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 22a0295086ae4f4ec26df00a0e077eecfa27f1fb
>
>
> Diff: https://reviews.apache.org/r/70135/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70135: Improved isolation for slave tests.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70135/#review213459
-----------------------------------------------------------
Why does it related to orphan containers?
- Gilbert Song
On March 5, 2019, 9:10 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70135/
> -----------------------------------------------------------
>
> (Updated March 5, 2019, 9:10 p.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improved isolation of the `SlaveTest` fixture so it won't pick up
> "orphaned" containers when running as root.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 22a0295086ae4f4ec26df00a0e077eecfa27f1fb
>
>
> Diff: https://reviews.apache.org/r/70135/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>