You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/04 11:48:00 UTC

[GitHub] [spark] juliuszsompolski commented on pull request #28705: [SPARK-30808][SQL] Enable Java 8 time API in in Thriftserver SQL CLI

juliuszsompolski commented on pull request #28705:
URL: https://github.com/apache/spark/pull/28705#issuecomment-638798320


   Thanks for the explanations @MaxGekk . I agree it's a good fix to make it use the Java8 APIs all across the Thriftserver.
   I would however do it in SparkSQLDriver like you did in https://github.com/apache/spark/commit/916838a3d43aeac59cdc799fed0de8d279b0ad66 instead of changing toHiveResult, and I would also add it to the withLocalProperties wrapper in SparkOperation, that will apply it to the Thriftserver JDBC/ODBC operations.
   WDYT @cloud-fan ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org