[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #285: update links to point to pekko sample docs

["pjfanning (via GitHub)" <gi...@apache.org>]

pjfanning commented on code in PR #285:
URL: https://github.com/apache/incubator-pekko/pull/285#discussion_r1166493721


##########
project/Paradox.scala:
##########
@@ -35,8 +35,8 @@ object Paradox {
       "extref.platform-guide.base_url" -> "https://developer.lightbend.com/docs/akka-platform-guide/%s",
       "extref.wikipedia.base_url" -> "https://en.wikipedia.org/wiki/%s",
       "extref.github.base_url" -> (GitHub.url(version.value) + "/%s"), // for links to our sources
-      "extref.samples.base_url" -> "https://developer.lightbend.com/start/?group=akka&project=%s",
-      "extref.ecs.base_url" -> "https://example.lightbend.com/v1/download/%s",
+      "extref.samples.base_url" -> s"$pekkoBaseURL/docs/pekko-samples/current/%s",
+      "extref.akka-samples.base_url" -> "https://developer.lightbend.com/start/?group=akka&project=%s",
       "pekko.doc.dns" -> s"$pekkoBaseURL",

Review Comment:
   We don't have Pekko versions of all the samples. `"extref.akka-samples.base_url"` has the same value as the previous setting for `"extref.samples.base_url"`. I've changed some of the `extref` settings in the docs to use this `akka-samples` based link - so that the generated link URL remains as before - because the `samples` based links have been changed to link to Pekko URLs if and when there is an actual working Pekko sample to link to.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org