You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Amichai Rothman (JIRA)" <se...@james.apache.org> on 2009/05/09 01:22:45 UTC

[jira] Commented: (JAMES-900) NullPointerException during local delivery spooling

    [ https://issues.apache.org/jira/browse/JAMES-900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707554#action_12707554 ] 

Amichai Rothman commented on JAMES-900:
---------------------------------------

I've made good progress analyzing the logs some more - I've found a correspondence between these errors and errors in the mailet logs (see below). The mail identifier in the last line is the one that appears also in the spoolmanager logs. So I suppose the bug can be rephrased as: a message with a mime format error cannot be stored in the error store.

Note that I first tried a simple fix for #1 and #2, namely adding the synchronized modifier to the methods MessageReferenceTracker.getWrapped(),  getWrappedMessageForWriting() and getWrappedMessage() in the MimeMessageCopyOnWriteProxy class. u might want to make these changes anyway because the code as it is does have potential bugs without them, even if not this specific error.



02/05/09 04:07:50 INFO  James.Mailet: Error while storing mail.
javax.mail.MessagingException: Exception caught while storing mail Container: ;
  nested exception is:
	javax.mail.MessagingException: IOException while copying message;
  nested exception is:
	com.sun.mail.util.DecodingException: BASE64Decoder: Error in encoded stream: needed 4 valid base64 characters but only got 2 before EOF, the 10 most recent characters were: "\130\190\130\179\130\162\129B\r\n"
	at org.apache.james.mailrepository.JDBCMailRepository.store(JDBCMailRepository.java:764)
	at org.apache.james.transport.mailets.ToMultiRepository.storeMail(ToMultiRepository.java:230)
	at org.apache.james.transport.mailets.ToMultiRepository.service(ToMultiRepository.java:154)
	at org.apache.james.transport.mailets.LocalDelivery.service(LocalDelivery.java:66)
	at org.apache.james.transport.LinearProcessor.service(LinearProcessor.java:424)
	at org.apache.james.transport.JamesSpoolManager.process(JamesSpoolManager.java:405)
	at org.apache.james.transport.JamesSpoolManager.run(JamesSpoolManager.java:309)
	at java.lang.Thread.run(Unknown Source)
Caused by: javax.mail.MessagingException: IOException while copying message;
  nested exception is:
	com.sun.mail.util.DecodingException: BASE64Decoder: Error in encoded stream: needed 4 valid base64 characters but only got 2 before EOF, the 10 most recent characters were: "\130\190\130\179\130\162\129B\r\n"
	at org.apache.james.core.MimeMessageWrapper.<init>(MimeMessageWrapper.java:149)
	at org.apache.james.core.MimeMessageCopyOnWriteProxy.getWrappedMessageForWriting(MimeMessageCopyOnWriteProxy.java:149)
	at org.apache.james.core.MimeMessageCopyOnWriteProxy.saveChanges(MimeMessageCopyOnWriteProxy.java:687)
	at org.apache.james.core.MimeMessageUtil.writeToInternal(MimeMessageUtil.java:84)
	at org.apache.james.core.MimeMessageUtil.writeTo(MimeMessageUtil.java:70)
	at org.apache.james.core.MimeMessageUtil.writeTo(MimeMessageUtil.java:50)
	at org.apache.james.mailrepository.MessageInputStream.writeStream(MessageInputStream.java:112)
	at org.apache.james.mailrepository.MessageInputStream.<init>(MessageInputStream.java:82)
	at org.apache.james.mailrepository.JDBCMailRepository.store(JDBCMailRepository.java:718)
	... 7 more
Caused by: com.sun.mail.util.DecodingException: BASE64Decoder: Error in encoded stream: needed 4 valid base64 characters but only got 2 before EOF, the 10 most recent characters were: "\130\190\130\179\130\162\129B\r\n"
	at com.sun.mail.util.BASE64DecoderStream.decode(BASE64DecoderStream.java:252)
	at com.sun.mail.util.BASE64DecoderStream.read(BASE64DecoderStream.java:140)
	at java.io.FilterInputStream.read(Unknown Source)
	at org.apache.james.core.MimeMessageUtil.copyStream(MimeMessageUtil.java:167)
	at org.apache.james.core.MimeMessageUtil.writeMessageBodyTo(MimeMessageUtil.java:152)
	at org.apache.james.core.MimeMessageUtil.writeToInternal(MimeMessageUtil.java:90)
	at org.apache.james.core.MimeMessageWrapper.writeTo(MimeMessageWrapper.java:281)
	at org.apache.james.core.MimeMessageWrapper.writeTo(MimeMessageWrapper.java:257)
	at org.apache.james.core.MimeMessageWrapper.writeTo(MimeMessageWrapper.java:242)
	at org.apache.james.core.MimeMessageWrapper.<init>(MimeMessageWrapper.java:140)
	... 15 more
02/05/09 04:07:50 INFO  James.Mailet: ToRepository: Storing mail Mail1241237254190-37952 in db://maildb/deadletter/error



> NullPointerException during local delivery spooling
> ---------------------------------------------------
>
>                 Key: JAMES-900
>                 URL: https://issues.apache.org/jira/browse/JAMES-900
>             Project: JAMES Server
>          Issue Type: Bug
>          Components: SpoolManager & Processors
>    Affects Versions: 2.3.1
>         Environment: Windows XP, Sun JDK 1.6.0_12, MySQL 5.0 backend
>            Reporter: Amichai Rothman
>
> The exception below occurs 1-2 times a day on a server handling between a few hundred and a few thousands of messages per day.
> I took a short look at the code, and it looks like there's a MimeMessageCopyOnWriteProxy wrapping a null message. A few possible causes:
> - MessageReferenceTracker.getWrapped() should be synchronized, as the field is neither final nor volatile and so it's possible that a thread other than the one which creates it will see a null wrapped message.
> - the refCount field is not properly synchronized nor volatile so methods which set/replace its value (private constructor, getWrappedMessageForWriting) may cause some threads to see the new instance and some the old one. this can result in buggy reference counting, which can result in the wrapped message being set to null (when reference count is decreased too much) and then being accessed.
> - a MailImpl is being constructed (or copy-constructed) somewhere with a null message (which is passed on to the proxy class).
> - something completely different.
> The stacktrace from spoolmanager log:
> 25/04/09 02:00:58 ERROR spoolmanager.transport: Exception calling LocalDelivery: Exception spooling message: Exception caught while storing mail Container: 
> javax.mail.MessagingException: Exception spooling message: Exception caught while storing mail Container: ;
>   nested exception is:
> 	javax.mail.MessagingException: Exception caught while storing mail Container: ;
>   nested exception is:
> 	java.lang.NullPointerException
> 	at org.apache.james.James.sendMail(James.java:501)
> 	at org.apache.james.James.sendMail(James.java:454)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> 	at java.lang.reflect.Method.invoke(Unknown Source)
> 	at org.apache.avalon.phoenix.components.application.BlockInvocationHandler.invoke(BlockInvocationHandler.java:134)
> 	at $Proxy9.sendMail(Unknown Source)
> 	at org.apache.james.transport.mailets.ToMultiRepository.service(ToMultiRepository.java:183)
> 	at org.apache.james.transport.mailets.LocalDelivery.service(LocalDelivery.java:66)
> 	at org.apache.james.transport.LinearProcessor.service(LinearProcessor.java:424)
> 	at org.apache.james.transport.JamesSpoolManager.process(JamesSpoolManager.java:405)
> 	at org.apache.james.transport.JamesSpoolManager.run(JamesSpoolManager.java:309)
> 	at java.lang.Thread.run(Unknown Source)
> Caused by: javax.mail.MessagingException: Exception caught while storing mail Container: ;
>   nested exception is:
> 	java.lang.NullPointerException
> 	at org.apache.james.mailrepository.JDBCMailRepository.store(JDBCMailRepository.java:764)
> 	at org.apache.james.mailrepository.JDBCSpoolRepository.store(JDBCSpoolRepository.java:240)
> 	at org.apache.james.mailrepository.MailStoreSpoolRepository.store(MailStoreSpoolRepository.java:126)
> 	at sun.reflect.GeneratedMethodAccessor10.invoke(Unknown Source)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> 	at java.lang.reflect.Method.invoke(Unknown Source)
> 	at org.apache.avalon.phoenix.components.application.BlockInvocationHandler.invoke(BlockInvocationHandler.java:134)
> 	at $Proxy5.store(Unknown Source)
> 	at org.apache.james.James.sendMail(James.java:493)
> 	... 13 more
> Caused by: java.lang.NullPointerException
> 	at org.apache.james.core.MimeMessageUtil.calculateMessageSize(MimeMessageUtil.java:277)
> 	at org.apache.james.core.MimeMessageUtil.getMessageSize(MimeMessageUtil.java:261)
> 	at org.apache.james.core.MimeMessageCopyOnWriteProxy.getMessageSize(MimeMessageCopyOnWriteProxy.java:745)
> 	at org.apache.james.core.MimeMessageUtil.getMessageSize(MimeMessageUtil.java:257)
> 	at org.apache.james.core.MailImpl.getMessageSize(MailImpl.java:372)
> 	at org.apache.james.mailrepository.MessageInputStream.<init>(MessageInputStream.java:53)
> 	at org.apache.james.mailrepository.JDBCMailRepository.store(JDBCMailRepository.java:718)
> 	... 21 more
> javax.mail.MessagingException: Exception caught while storing mail Container: ;
>   nested exception is:
> 	java.lang.NullPointerException
> 	at org.apache.james.mailrepository.JDBCMailRepository.store(JDBCMailRepository.java:764)
> 	at org.apache.james.mailrepository.JDBCSpoolRepository.store(JDBCSpoolRepository.java:240)
> 	at org.apache.james.mailrepository.MailStoreSpoolRepository.store(MailStoreSpoolRepository.java:126)
> 	at sun.reflect.GeneratedMethodAccessor10.invoke(Unknown Source)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> 	at java.lang.reflect.Method.invoke(Unknown Source)
> 	at org.apache.avalon.phoenix.components.application.BlockInvocationHandler.invoke(BlockInvocationHandler.java:134)
> 	at $Proxy5.store(Unknown Source)
> 	at org.apache.james.James.sendMail(James.java:493)
> 	at org.apache.james.James.sendMail(James.java:454)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> 	at java.lang.reflect.Method.invoke(Unknown Source)
> 	at org.apache.avalon.phoenix.components.application.BlockInvocationHandler.invoke(BlockInvocationHandler.java:134)
> 	at $Proxy9.sendMail(Unknown Source)
> 	at org.apache.james.transport.mailets.ToMultiRepository.service(ToMultiRepository.java:183)
> 	at org.apache.james.transport.mailets.LocalDelivery.service(LocalDelivery.java:66)
> 	at org.apache.james.transport.LinearProcessor.service(LinearProcessor.java:424)
> 	at org.apache.james.transport.JamesSpoolManager.process(JamesSpoolManager.java:405)
> 	at org.apache.james.transport.JamesSpoolManager.run(JamesSpoolManager.java:309)
> 	at java.lang.Thread.run(Unknown Source)
> Caused by: java.lang.NullPointerException
> 	at org.apache.james.core.MimeMessageUtil.calculateMessageSize(MimeMessageUtil.java:277)
> 	at org.apache.james.core.MimeMessageUtil.getMessageSize(MimeMessageUtil.java:261)
> 	at org.apache.james.core.MimeMessageCopyOnWriteProxy.getMessageSize(MimeMessageCopyOnWriteProxy.java:745)
> 	at org.apache.james.core.MimeMessageUtil.getMessageSize(MimeMessageUtil.java:257)
> 	at org.apache.james.core.MailImpl.getMessageSize(MailImpl.java:372)
> 	at org.apache.james.mailrepository.MessageInputStream.<init>(MessageInputStream.java:53)
> 	at org.apache.james.mailrepository.JDBCMailRepository.store(JDBCMailRepository.java:718)
> 	... 21 more
> java.lang.NullPointerException
> 	at org.apache.james.core.MimeMessageUtil.calculateMessageSize(MimeMessageUtil.java:277)
> 	at org.apache.james.core.MimeMessageUtil.getMessageSize(MimeMessageUtil.java:261)
> 	at org.apache.james.core.MimeMessageCopyOnWriteProxy.getMessageSize(MimeMessageCopyOnWriteProxy.java:745)
> 	at org.apache.james.core.MimeMessageUtil.getMessageSize(MimeMessageUtil.java:257)
> 	at org.apache.james.core.MailImpl.getMessageSize(MailImpl.java:372)
> 	at org.apache.james.mailrepository.MessageInputStream.<init>(MessageInputStream.java:53)
> 	at org.apache.james.mailrepository.JDBCMailRepository.store(JDBCMailRepository.java:718)
> 	at org.apache.james.mailrepository.JDBCSpoolRepository.store(JDBCSpoolRepository.java:240)
> 	at org.apache.james.mailrepository.MailStoreSpoolRepository.store(MailStoreSpoolRepository.java:126)
> 	at sun.reflect.GeneratedMethodAccessor10.invoke(Unknown Source)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> 	at java.lang.reflect.Method.invoke(Unknown Source)
> 	at org.apache.avalon.phoenix.components.application.BlockInvocationHandler.invoke(BlockInvocationHandler.java:134)
> 	at $Proxy5.store(Unknown Source)
> 	at org.apache.james.James.sendMail(James.java:493)
> 	at org.apache.james.James.sendMail(James.java:454)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> 	at java.lang.reflect.Method.invoke(Unknown Source)
> 	at org.apache.avalon.phoenix.components.application.BlockInvocationHandler.invoke(BlockInvocationHandler.java:134)
> 	at $Proxy9.sendMail(Unknown Source)
> 	at org.apache.james.transport.mailets.ToMultiRepository.service(ToMultiRepository.java:183)
> 	at org.apache.james.transport.mailets.LocalDelivery.service(LocalDelivery.java:66)
> 	at org.apache.james.transport.LinearProcessor.service(LinearProcessor.java:424)
> 	at org.apache.james.transport.JamesSpoolManager.process(JamesSpoolManager.java:405)
> 	at org.apache.james.transport.JamesSpoolManager.run(JamesSpoolManager.java:309)
> 	at java.lang.Thread.run(Unknown Source)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org