You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Martin Blom (JIRA)" <ji...@apache.org> on 2011/02/17 09:21:24 UTC
[jira] Created: (HBASE-3542) MultiGet methods in Thrift
MultiGet methods in Thrift
--------------------------
Key: HBASE-3542
URL: https://issues.apache.org/jira/browse/HBASE-3542
Project: HBase
Issue Type: Improvement
Components: thrift
Affects Versions: 0.90.0
Reporter: Martin Blom
The Thrift API does not expose multi-get operations. This patch adds the meyhods getRows, getRowsWithColumns, getRowsTs and getRowsWithColumnsTs.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HBASE-3542) MultiGet methods in Thrift
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ryan rawson updated HBASE-3542:
-------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
trunk and branch
> MultiGet methods in Thrift
> --------------------------
>
> Key: HBASE-3542
> URL: https://issues.apache.org/jira/browse/HBASE-3542
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.90.0
> Reporter: Martin Blom
> Assignee: Martin Blom
> Fix For: 0.90.2
>
> Attachments: HBASE-3542[0.90].patch, HBASE-3542[0.90].v2.patch
>
>
> The Thrift API does not expose multi-get operations. This patch adds the meyhods getRows, getRowsWithColumns, getRowsTs and getRowsWithColumnsTs.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3542) MultiGet methods in Thrift
Posted by "Martin Blom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996290#comment-12996290 ]
Martin Blom commented on HBASE-3542:
------------------------------------
You prefer the getRows* functions at the bottom and not together with getRow*? I can do that. I was just trying to arrange them like the mutateRow*/mutateRows* functions are arranged.
Are you also suggesting that I should hand-edit the gernerated code? Or do you have a pointer to the exact version of thrift that was used to generate the current files?
Indentation in ThriftServer.java should be like the rest of the code in that file, except for the tabs. Sorry about that. ThriftServer.java does not comply to the standard indentation. Should I reformat the whole file?
> MultiGet methods in Thrift
> --------------------------
>
> Key: HBASE-3542
> URL: https://issues.apache.org/jira/browse/HBASE-3542
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.90.0
> Reporter: Martin Blom
> Attachments: HBASE-3542[0.90].patch
>
>
> The Thrift API does not expose multi-get operations. This patch adds the meyhods getRows, getRowsWithColumns, getRowsTs and getRowsWithColumnsTs.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3542) MultiGet methods in Thrift
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996053#comment-12996053 ]
ryan rawson commented on HBASE-3542:
------------------------------------
some major things:
- adding new methods to the bottom of the .thrift file means the resulting generated files have a minimum of changes.
- I'm showing files that are "changed" by virtue of having their license removed and having trailing spaces added. Should be fixed!
- lots of white space changes in Hbase.java, shouldnt exist. many IDEs can strip whitespace changes for you.
- indentation in ThriftServer.java is off. The project standard is no tabs, 2 spaces per level, 4 spaces for continuing indent. If you set 2/4 in intellij it will do the right thing, eclipse has similar settings.
> MultiGet methods in Thrift
> --------------------------
>
> Key: HBASE-3542
> URL: https://issues.apache.org/jira/browse/HBASE-3542
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.90.0
> Reporter: Martin Blom
> Attachments: HBASE-3542[0.90].patch
>
>
> The Thrift API does not expose multi-get operations. This patch adds the meyhods getRows, getRowsWithColumns, getRowsTs and getRowsWithColumnsTs.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3542) MultiGet methods in Thrift
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996012#comment-12996012 ]
ryan rawson commented on HBASE-3542:
------------------------------------
not yet, there is a big pile of junk in there that needs to be worked thru, im still testing other things at the moment.
our api is not that fancy and uses weird names like 'parallelGet'.
Any implementation though should use multi() to accomplish it's task.
> MultiGet methods in Thrift
> --------------------------
>
> Key: HBASE-3542
> URL: https://issues.apache.org/jira/browse/HBASE-3542
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.90.0
> Reporter: Martin Blom
> Attachments: HBASE-3542[0.90].patch
>
>
> The Thrift API does not expose multi-get operations. This patch adds the meyhods getRows, getRowsWithColumns, getRowsTs and getRowsWithColumnsTs.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3542) MultiGet methods in Thrift
Posted by "Martin Blom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996304#comment-12996304 ]
Martin Blom commented on HBASE-3542:
------------------------------------
I used ".../thrift-0.2.0/bin/thrift --gen java:hashcode .../Hbase.thrift" to generate the code, then removed trailing spaces and added the license.
The generated changes in AlreadyExists.java are rather pointless, so maybe it should be excluded.
> MultiGet methods in Thrift
> --------------------------
>
> Key: HBASE-3542
> URL: https://issues.apache.org/jira/browse/HBASE-3542
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.90.0
> Reporter: Martin Blom
> Attachments: HBASE-3542[0.90].patch, HBASE-3542[0.90].v2.patch
>
>
> The Thrift API does not expose multi-get operations. This patch adds the meyhods getRows, getRowsWithColumns, getRowsTs and getRowsWithColumnsTs.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HBASE-3542) MultiGet methods in Thrift
Posted by "Martin Blom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Blom updated HBASE-3542:
-------------------------------
Attachment: HBASE-3542[0.90].patch
ThriftServer.java and Hbase.thrift patched manually, the other files generated using thrift-0.2.0
> MultiGet methods in Thrift
> --------------------------
>
> Key: HBASE-3542
> URL: https://issues.apache.org/jira/browse/HBASE-3542
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.90.0
> Reporter: Martin Blom
> Attachments: HBASE-3542[0.90].patch
>
>
> The Thrift API does not expose multi-get operations. This patch adds the meyhods getRows, getRowsWithColumns, getRowsTs and getRowsWithColumnsTs.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3542) MultiGet methods in Thrift
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998643#comment-12998643 ]
Hudson commented on HBASE-3542:
-------------------------------
Integrated in HBase-TRUNK #1748 (See [https://hudson.apache.org/hudson/job/HBase-TRUNK/1748/])
HBASE-3542 MultiGet methods in Thrift
> MultiGet methods in Thrift
> --------------------------
>
> Key: HBASE-3542
> URL: https://issues.apache.org/jira/browse/HBASE-3542
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.90.0
> Reporter: Martin Blom
> Assignee: Martin Blom
> Fix For: 0.90.2
>
> Attachments: HBASE-3542[0.90].patch, HBASE-3542[0.90].v2.patch
>
>
> The Thrift API does not expose multi-get operations. This patch adds the meyhods getRows, getRowsWithColumns, getRowsTs and getRowsWithColumnsTs.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HBASE-3542) MultiGet methods in Thrift
Posted by "Martin Blom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Blom updated HBASE-3542:
-------------------------------
Attachment: HBASE-3542[0.90].v2.patch
Deleted trailing spaces from generated code and re-added the license.
Replaced tabs with spaces in ThriftServer.java.
> MultiGet methods in Thrift
> --------------------------
>
> Key: HBASE-3542
> URL: https://issues.apache.org/jira/browse/HBASE-3542
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.90.0
> Reporter: Martin Blom
> Attachments: HBASE-3542[0.90].patch, HBASE-3542[0.90].v2.patch
>
>
> The Thrift API does not expose multi-get operations. This patch adds the meyhods getRows, getRowsWithColumns, getRowsTs and getRowsWithColumnsTs.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HBASE-3542) MultiGet methods in Thrift
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-3542:
-------------------------
Fix Version/s: 0.90.2
Status: Patch Available (was: Open)
Marking patch available; just needs last review.
> MultiGet methods in Thrift
> --------------------------
>
> Key: HBASE-3542
> URL: https://issues.apache.org/jira/browse/HBASE-3542
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.90.0
> Reporter: Martin Blom
> Fix For: 0.90.2
>
> Attachments: HBASE-3542[0.90].patch, HBASE-3542[0.90].v2.patch
>
>
> The Thrift API does not expose multi-get operations. This patch adds the meyhods getRows, getRowsWithColumns, getRowsTs and getRowsWithColumnsTs.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HBASE-3542) MultiGet methods in Thrift
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack reassigned HBASE-3542:
----------------------------
Assignee: Martin Blom
> MultiGet methods in Thrift
> --------------------------
>
> Key: HBASE-3542
> URL: https://issues.apache.org/jira/browse/HBASE-3542
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.90.0
> Reporter: Martin Blom
> Assignee: Martin Blom
> Fix For: 0.90.2
>
> Attachments: HBASE-3542[0.90].patch, HBASE-3542[0.90].v2.patch
>
>
> The Thrift API does not expose multi-get operations. This patch adds the meyhods getRows, getRowsWithColumns, getRowsTs and getRowsWithColumnsTs.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3542) MultiGet methods in Thrift
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996292#comment-12996292 ]
ryan rawson commented on HBASE-3542:
------------------------------------
I think if you removed trailing spaces from generated files, added in the
license and double checked the ThriftServer tabs we'll be there.
Part of the reason to put calls at the bottom is to minimize the changes to
the huge Hbase.java and make the change easier to understand/rationalize.
> MultiGet methods in Thrift
> --------------------------
>
> Key: HBASE-3542
> URL: https://issues.apache.org/jira/browse/HBASE-3542
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.90.0
> Reporter: Martin Blom
> Attachments: HBASE-3542[0.90].patch
>
>
> The Thrift API does not expose multi-get operations. This patch adds the meyhods getRows, getRowsWithColumns, getRowsTs and getRowsWithColumnsTs.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3542) MultiGet methods in Thrift
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995952#comment-12995952 ]
stack commented on HBASE-3542:
------------------------------
@Martin You tested this? Does it work for you?
We should pull this in for 0.90.2 if its working (though a 'feature' rather than bugfix).
@Ryan Did you put up your patch for trunk adding multiget to thrift?
> MultiGet methods in Thrift
> --------------------------
>
> Key: HBASE-3542
> URL: https://issues.apache.org/jira/browse/HBASE-3542
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.90.0
> Reporter: Martin Blom
> Attachments: HBASE-3542[0.90].patch
>
>
> The Thrift API does not expose multi-get operations. This patch adds the meyhods getRows, getRowsWithColumns, getRowsTs and getRowsWithColumnsTs.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira