You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/15 23:06:04 UTC
[jira] [Commented] (BOOKKEEPER-1055) Optimize handling of masterKey
in case it is empty
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011470#comment-16011470 ]
ASF GitHub Bot commented on BOOKKEEPER-1055:
--------------------------------------------
GitHub user merlimat opened a pull request:
https://github.com/apache/bookkeeper/pull/156
BOOKKEEPER-1055: Optimize handling of masterKey in case it is empty
On each request client and bookies are exchanging the ledger masterKey, which is a 20 bytes MAC digest of the ledger password.
For each request there is a considerable overhead in allocating byte arrays when parsing the add/read requests.
If the client is a passing an empty password, we should optimize the data path to skip all allocations (related to the masterKey) and instead rely on a static byte array.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/merlimat/bookkeeper empty-password
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bookkeeper/pull/156.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #156
----
commit 33ed98a7653ca82eb2d25cafbad51f6b6fa0dac7
Author: Matteo Merli <mm...@yahoo-inc.com>
Date: 2015-05-11T03:59:41Z
BOOKKEEPER-1055: Optimize handling of masterKey in case it is empty
----
> Optimize handling of masterKey in case it is empty
> --------------------------------------------------
>
> Key: BOOKKEEPER-1055
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1055
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Matteo Merli
> Assignee: Matteo Merli
> Priority: Minor
> Fix For: 4.5.0
>
>
> On each request client and bookies are exchanging the ledger masterKey, which is a 20 bytes MAC digest of the ledger password.
> For each request there is a considerable overhead in allocating byte arrays when parsing the add/read requests.
> If the client is a passing an empty password, we should optimize the data path to skip all allocations (related to the masterKey) and instead rely on a static byte array.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)