You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Amogh Vasekar <am...@citrix.com> on 2013/07/26 20:22:35 UTC
Review Request 12976: Remove duplicate row from guest_os table
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12976/
-----------------------------------------------------------
Review request for cloudstack, Alena Prokharchyk and Venkata Siva Vijayendra Bhamidipati.
Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3647
Repository: cloudstack-git
Description
-------
Remove duplicate row (id=206) from table guest_os.
Decided to remove instead of checking for duplicates on insertion since :
1. The new row is referenced by id=166 elsewhere in the DB
2. Old row with id=206 is not referenced in DB
Diffs
-----
setup/db/db/schema-410to420.sql 82ca403
Diff: https://reviews.apache.org/r/12976/diff/
Testing
-------
Local environment
Thanks,
Amogh Vasekar
Re: Review Request 12976: Remove duplicate row from guest_os table
Posted by "Jenkins Cloudstack.org" <hu...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12976/#review23964
-----------------------------------------------------------
Review 12976 PASSED the build test
The url of build cloudstack-master-with-patch #53 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/53/
- Jenkins Cloudstack.org
On July 26, 2013, 6:22 p.m., Amogh Vasekar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12976/
> -----------------------------------------------------------
>
> (Updated July 26, 2013, 6:22 p.m.)
>
>
> Review request for cloudstack, Alena Prokharchyk and Venkata Siva Vijayendra Bhamidipati.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3647
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Remove duplicate row (id=206) from table guest_os.
> Decided to remove instead of checking for duplicates on insertion since :
> 1. The new row is referenced by id=166 elsewhere in the DB
> 2. Old row with id=206 is not referenced in DB
>
>
> Diffs
> -----
>
> setup/db/db/schema-410to420.sql 82ca403
>
> Diff: https://reviews.apache.org/r/12976/diff/
>
>
> Testing
> -------
>
> Local environment
>
>
> Thanks,
>
> Amogh Vasekar
>
>
Re: Review Request 12976: Remove duplicate row from guest_os table
Posted by Alena Prokharchyk <al...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12976/#review24590
-----------------------------------------------------------
Ship it!
Ship It!
- Alena Prokharchyk
On Aug. 2, 2013, 10:43 p.m., Amogh Vasekar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12976/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2013, 10:43 p.m.)
>
>
> Review request for cloudstack, Alena Prokharchyk and Venkata Siva Vijayendra Bhamidipati.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3647
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Remove duplicate row (id=206) from table guest_os.
> Decided to remove instead of checking for duplicates on insertion since :
> 1. The new row is referenced by id=166 elsewhere in the DB
> 2. Old row with id=206 is not referenced in DB
>
>
> Diffs
> -----
>
> setup/db/db/schema-410to420.sql b2fe2ed
>
> Diff: https://reviews.apache.org/r/12976/diff/
>
>
> Testing
> -------
>
> Local environment
>
>
> Thanks,
>
> Amogh Vasekar
>
>
Re: Review Request 12976: Remove duplicate row from guest_os table
Posted by Amogh Vasekar <am...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12976/
-----------------------------------------------------------
(Updated Aug. 2, 2013, 10:43 p.m.)
Review request for cloudstack, Alena Prokharchyk and Venkata Siva Vijayendra Bhamidipati.
Changes
-------
Hi,
Have created a new patch with the latest master.
Thanks!
Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3647
Repository: cloudstack-git
Description
-------
Remove duplicate row (id=206) from table guest_os.
Decided to remove instead of checking for duplicates on insertion since :
1. The new row is referenced by id=166 elsewhere in the DB
2. Old row with id=206 is not referenced in DB
Diffs (updated)
-----
setup/db/db/schema-410to420.sql b2fe2ed
Diff: https://reviews.apache.org/r/12976/diff/
Testing
-------
Local environment
Thanks,
Amogh Vasekar
Re: Review Request 12976: Remove duplicate row from guest_os table
Posted by Alena Prokharchyk <al...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12976/#review24559
-----------------------------------------------------------
The fix is good, but the patch failed to apply:
alena@macbookpro: [4.2]~/cloudstack-oss$ git am ~/Desktop/db_remove_206_row.patch.2 --whitespace=nowarn
Applying: Removing duplicate unreferenced row
error: patch failed: setup/db/db/schema-410to420.sql:276
error: setup/db/db/schema-410to420.sql: patch does not apply
Patch failed at 0001 Removing duplicate unreferenced row
The copy of the patch that failed is found in:
/Users/alena/cloudstack-oss/.git/rebase-apply/patch
When you have resolved this problem, run "git am --resolved".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
- Alena Prokharchyk
On July 27, 2013, 7:22 p.m., Amogh Vasekar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12976/
> -----------------------------------------------------------
>
> (Updated July 27, 2013, 7:22 p.m.)
>
>
> Review request for cloudstack, Alena Prokharchyk and Venkata Siva Vijayendra Bhamidipati.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3647
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Remove duplicate row (id=206) from table guest_os.
> Decided to remove instead of checking for duplicates on insertion since :
> 1. The new row is referenced by id=166 elsewhere in the DB
> 2. Old row with id=206 is not referenced in DB
>
>
> Diffs
> -----
>
> setup/db/db/schema-410to420.sql 82ca403
> setup/db/db/schema-410to420.sql 82ca403
>
> Diff: https://reviews.apache.org/r/12976/diff/
>
>
> Testing
> -------
>
> Local environment
>
>
> Thanks,
>
> Amogh Vasekar
>
>
Re: Review Request 12976: Remove duplicate row from guest_os table
Posted by Amogh Vasekar <am...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12976/
-----------------------------------------------------------
(Updated July 27, 2013, 7:22 p.m.)
Review request for cloudstack, Alena Prokharchyk and Venkata Siva Vijayendra Bhamidipati.
Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3647
Repository: cloudstack-git
Description
-------
Remove duplicate row (id=206) from table guest_os.
Decided to remove instead of checking for duplicates on insertion since :
1. The new row is referenced by id=166 elsewhere in the DB
2. Old row with id=206 is not referenced in DB
Diffs
-----
setup/db/db/schema-410to420.sql 82ca403
setup/db/db/schema-410to420.sql 82ca403
Diff: https://reviews.apache.org/r/12976/diff/
Testing
-------
Local environment
Thanks,
Amogh Vasekar
Re: Review Request 12976: Remove duplicate row from guest_os table
Posted by Amogh Vasekar <am...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12976/
-----------------------------------------------------------
(Updated July 27, 2013, 7:21 p.m.)
Review request for cloudstack, Alena Prokharchyk and Venkata Siva Vijayendra Bhamidipati.
Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3647
Repository: cloudstack-git
Description
-------
Remove duplicate row (id=206) from table guest_os.
Decided to remove instead of checking for duplicates on insertion since :
1. The new row is referenced by id=166 elsewhere in the DB
2. Old row with id=206 is not referenced in DB
Diffs (updated)
-----
setup/db/db/schema-410to420.sql 82ca403
setup/db/db/schema-410to420.sql 82ca403
Diff: https://reviews.apache.org/r/12976/diff/
Testing
-------
Local environment
Thanks,
Amogh Vasekar
Re: Review Request 12976: Remove duplicate row from guest_os table
Posted by Amogh Vasekar <am...@citrix.com>.
> On July 26, 2013, 11:51 p.m., Alena Prokharchyk wrote:
> > We can't just remove the row w/o making sure its not being referenced by existing resources. So putting "DELETE IGNORE FROM `cloud`.`guest_os` where id=206" is not enough. You can go 2 ways:
> >
> > #1 - don't insert the record to the DB if it already exists (if upgraded from 3.0.x) during 41-42 upgrade.
> >
> > #2 - transfer all the records referencing guest os id=206, to use the guest_os inserted as a part of 41-42 upgrade.
Thanks Alena for reviewing.
The understanding was that the row with id=206 was not being referenced elsewhere. Nonetheless, I have added UPDATE statements for tables that might reference guest_os.id directly.
#1 wasnt feasible since the new row is being referenced directly with the new id in guest_os_hypervisor table.
- Amogh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12976/#review23996
-----------------------------------------------------------
On July 26, 2013, 6:22 p.m., Amogh Vasekar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12976/
> -----------------------------------------------------------
>
> (Updated July 26, 2013, 6:22 p.m.)
>
>
> Review request for cloudstack, Alena Prokharchyk and Venkata Siva Vijayendra Bhamidipati.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3647
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Remove duplicate row (id=206) from table guest_os.
> Decided to remove instead of checking for duplicates on insertion since :
> 1. The new row is referenced by id=166 elsewhere in the DB
> 2. Old row with id=206 is not referenced in DB
>
>
> Diffs
> -----
>
> setup/db/db/schema-410to420.sql 82ca403
>
> Diff: https://reviews.apache.org/r/12976/diff/
>
>
> Testing
> -------
>
> Local environment
>
>
> Thanks,
>
> Amogh Vasekar
>
>
Re: Review Request 12976: Remove duplicate row from guest_os table
Posted by Alena Prokharchyk <al...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12976/#review23996
-----------------------------------------------------------
We can't just remove the row w/o making sure its not being referenced by existing resources. So putting "DELETE IGNORE FROM `cloud`.`guest_os` where id=206" is not enough. You can go 2 ways:
#1 - don't insert the record to the DB if it already exists (if upgraded from 3.0.x) during 41-42 upgrade.
#2 - transfer all the records referencing guest os id=206, to use the guest_os inserted as a part of 41-42 upgrade.
- Alena Prokharchyk
On July 26, 2013, 6:22 p.m., Amogh Vasekar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12976/
> -----------------------------------------------------------
>
> (Updated July 26, 2013, 6:22 p.m.)
>
>
> Review request for cloudstack, Alena Prokharchyk and Venkata Siva Vijayendra Bhamidipati.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3647
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Remove duplicate row (id=206) from table guest_os.
> Decided to remove instead of checking for duplicates on insertion since :
> 1. The new row is referenced by id=166 elsewhere in the DB
> 2. Old row with id=206 is not referenced in DB
>
>
> Diffs
> -----
>
> setup/db/db/schema-410to420.sql 82ca403
>
> Diff: https://reviews.apache.org/r/12976/diff/
>
>
> Testing
> -------
>
> Local environment
>
>
> Thanks,
>
> Amogh Vasekar
>
>