You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@subversion.apache.org by Evgeny Kotkov <ev...@visualsvn.com> on 2014/03/04 00:06:15 UTC

Re: [PATCH] Fix recover/hotcopy erroring out for old FSFS repositories

Hi Stefan,

> Except for the typo, you patch looks good.
> I like that we get around the chicken/egg
> problem with the revnum vs. HEAD check.
> Please commit.

I fixed the typo and committed this patch in r1573744.  Thank you for
the review.

> Mind applying equivalent changes to get_root_changes_offset()?

Done in r1573794.


Regards,
Evgeny Kotkov

Re: [PATCH] Fix recover/hotcopy erroring out for old FSFS repositories

Posted by Stefan Fuhrmann <st...@wandisco.com>.

On Tue, Mar 4, 2014 at 12:06 AM, Evgeny Kotkov
<ev...@visualsvn.com>wrote:

> Hi Stefan,
>
> > Except for the typo, you patch looks good.
> > I like that we get around the chicken/egg
> > problem with the revnum vs. HEAD check.
> > Please commit.
>
> I fixed the typo and committed this patch in r1573744.  Thank you for
> the review.
>
> > Mind applying equivalent changes to get_root_changes_offset()?
>
> Done in r1573794.
>

Yup, looks good. Thanks!

-- Stefan^2.