[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5996: HDFS-17171. CONGESTION_RATIO should be configurable

["ayushtkn (via GitHub)" <gi...@apache.org>]

ayushtkn commented on code in PR #5996:
URL: https://github.com/apache/hadoop/pull/5996#discussion_r1340969835


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java:
##########
@@ -614,6 +616,8 @@ public Map<String, Long> load(String key) {
         new DataTransferThrottler(100, ecReconstuctReadBandwidth) : null;
     this.ecReconstuctWriteThrottler = ecReconstuctWriteBandwidth > 0 ?
         new DataTransferThrottler(100, ecReconstuctWriteBandwidth) : null;
+    this.congestionRatio = conf.getDouble(DFSConfigKeys.DFS_PIPELINE_CONGESTION_RATIO,
+        DFSConfigKeys.DFS_PIPELINE_CONGESTION_RATIO_DEFAULT);

Review Comment:
   should validate the value is positive, if not put a warn log & use default



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org