[GitHub] [geode] aditya87 opened pull request #2802: [GEODE-5998] Add geospatial commands to Redis adapter

["aditya87 (GitHub)" <gi...@apache.org>]

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

**Note**: Replaces #2210 

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [X] Is your initial contribution a single, squashed commit?

- [X] Does `gradlew build` run cleanly?

- [X] Have you written or updated unit tests to verify your changes?

- [X] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2802 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] galen-pivotal closed pull request #2802: [GEODE-5998] Add geospatial commands to Redis adapter

["galen-pivotal (GitHub)" <gi...@apache.org>]

[ pull request closed by galen-pivotal ]

[ Full content available at: https://github.com/apache/geode/pull/2802 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] metatype commented on issue #2802: [GEODE-5998] Add geospatial commands to Redis adapter

["metatype (GitHub)" <gi...@apache.org>]

@galen-pivotal @aditya87 This already got merged but I have a few comments:

1) The new jars are all Apache licensed so that's good.  However, commons-math3 has some declarations in the notice file that need to be considered and probably added to our NOTICE for binary dependencies.  See https://git-wip-us.apache.org/repos/asf?p=commons-math.git;a=blob;f=NOTICE.txt;h=12232535fdcecf37638dee76fc177a5ddb28de1e;hb=7ec508828f62c2a3df31cde2a2f3aa32c5135fdb

2) The new jars are included in the lib/ dir but not added to the classpath.  Was this intended?  Did you test this from an integration test and/or command-line?

Thanks!

[ Full content available at: https://github.com/apache/geode/pull/2802 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org