[GitHub] QiuMM commented on a change in pull request #6335: Added backpressure metric

[GitBox <gi...@apache.org>]

QiuMM commented on a change in pull request #6335: Added backpressure metric
URL: https://github.com/apache/incubator-druid/pull/6335#discussion_r217940769
 
 

 ##########
 File path: server/src/main/java/org/apache/druid/client/DirectDruidClient.java
 ##########
 @@ -207,9 +207,12 @@ public int getNumOpenConnections()
         private final AtomicBoolean done = new AtomicBoolean(false);
         private final AtomicReference<String> fail = new AtomicReference<>();
         private final AtomicReference<TrafficCop> trafficCopRef = new AtomicReference<>();
+        private final AtomicReference<Boolean> isChannelReadable = new AtomicReference<>();
 
 Review comment:
   I would use `AtomicBoolean` not `AtomicReference<Boolean>`. And I think change variable name to `channelReadable` would be better since there are another variable `private final AtomicBoolean done = new AtomicBoolean(false)` in this file, it's not start with `is`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org