[GitHub] szha commented on a change in pull request #9471: Glossary takes token_indexer and token_embedding in its constructor

[GitBox <gi...@apache.org>]

szha commented on a change in pull request #9471: Glossary takes token_indexer and token_embedding in its constructor
URL: https://github.com/apache/incubator-mxnet/pull/9471#discussion_r162232123
 
 

 ##########
 File path: python/mxnet/contrib/text/glossary.py
 ##########
 @@ -31,35 +33,16 @@ class Glossary(embedding.TokenEmbedding):
 
     For each indexed token in a glossary, an embedding vector will be associated with it. Such
     embedding vectors can be loaded from externally hosted or custom pre-trained token embedding
-    files, such as via instances of :class:`~mxnet.text.embedding.TokenEmbedding`.
+    files, such as via instances of :class:`~mxnet.contrib.text.embedding.TokenEmbedding`.
 
 
     Parameters
     ----------
-    counter : collections.Counter or None, default None
-        Counts text token frequencies in the text data. Its keys will be indexed according to
-        frequency thresholds such as `most_freq_count` and `min_freq`. Keys of `counter`,
-        `unknown_token`, and values of `reserved_tokens` must be of the same hashable type.
-        Examples: str, int, and tuple.
+    token_indexer : :class:`~mxnet.contrib.text.indexer.TokenIndexer`
+        The indexed tokens to load.
 
 Review comment:
   The subject should be either index or indexer.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services