[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #2061: [SCB-2116] RateLimiting and Retry based on traffic characteristics

[GitBox <gi...@apache.org>]

liubao68 commented on a change in pull request #2061:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2061#discussion_r525877362



##########
File path: transports/transport-highway/src/main/java/org/apache/servicecomb/transport/highway/HighwayServerInvoke.java
##########
@@ -202,12 +202,16 @@ public void execute() {
     }
   }
 
-  private Holder<Boolean> checkQpsFlowControl(OperationMeta operationMeta) {
+  private boolean checkQpsFlowControl(OperationMeta operationMeta) {
     Holder<Boolean> qpsFlowControlReject = new Holder<>(false);
     @SuppressWarnings("deprecation")
     Handler providerQpsFlowControlHandler = operationMeta.getProviderQpsFlowControlHandler();
     if (null != providerQpsFlowControlHandler) {
       try {
+        Handler marKHandler = operationMeta.getMarkHandler();

Review comment:
       match & flowcontrol is different handler, and match should executed before flowcontrol. 
   
   It's better to add an new method like 'processmatch' to deal match handler.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org