You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2016/10/15 09:43:03 UTC

[Bug 60259] New: [PATCH] dispose temp file in test code

https://bz.apache.org/bugzilla/show_bug.cgi?id=60259

            Bug ID: 60259
           Summary: [PATCH] dispose temp file in test code
           Product: POI
           Version: 3.15-FINAL
          Hardware: PC
                OS: Mac OS X 10.1
            Status: NEW
          Severity: normal
          Priority: P2
         Component: SXSSF
          Assignee: dev@poi.apache.org
          Reporter: fanningpj@yahoo.com

Created attachment 34375
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34375&action=edit
[PATCH] dispose temp file in test code

A small issue in TestSXSSFWorkbookWithCustomZipEntrySource. As the inner
classes in the test could be used as the basis of writing a custom version of
SXSSFWorkbook, it would be nice to ensure that those classes close all the temp
resources they create.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 60259] [PATCH] dispose temp file in test code

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60259

Dominik Stadler <do...@gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|REOPENED                    |RESOLVED

--- Comment #3 from Dominik Stadler <do...@gmx.at> ---
Thanks, I have applied this via r1765100, although the file was cleaned up by
the TempFile implementation automatically as well and thus no file was left
over, but it is a bit cleaner this way.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 60259] [PATCH] dispose temp file in test code

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60259

Dominik Stadler <do...@gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
             Status|RESOLVED                    |REOPENED

--- Comment #2 from Dominik Stadler <do...@gmx.at> ---
Oh wait, I will take another look, maybe this is something else.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 60259] [PATCH] dispose temp file in test code

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60259

Dominik Stadler <do...@gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #1 from Dominik Stadler <do...@gmx.at> ---
Thanks for the patch, we already fixed this via r1765019, albeit in a different
way, maybe you can take a look if our approach is valid as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org