[GitHub] milleruntime commented on a change in pull request #487: Inline inner Rfile classes and interfaces

[GitBox <gi...@apache.org>]

milleruntime commented on a change in pull request #487: Inline inner Rfile classes and interfaces
URL: https://github.com/apache/accumulo/pull/487#discussion_r188735825
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/file/rfile/SplitLarge.java
 ##########
 @@ -71,10 +73,12 @@ public static void main(String[] args) throws Exception {
         int blockSize = (int) aconf.getAsBytes(Property.TABLE_FILE_BLOCK_SIZE);
         try (
             Writer small = new RFile.Writer(
-                new CachableBlockFile.Writer(fs, new Path(smallName), "gz", null, conf, aconf),
+                new BCFile.Writer(new RateLimitedOutputStream(fs.create(new Path(smallName)), null),
+                    "gz", conf, false, aconf),
                 blockSize);
             Writer large = new RFile.Writer(
-                new CachableBlockFile.Writer(fs, new Path(largeName), "gz", null, conf, aconf),
+                new BCFile.Writer(new RateLimitedOutputStream(fs.create(new Path(largeName)), null),
 
 Review comment:
   Yeah I think so, might be able to clean up the constructor.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services