You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/27 11:01:38 UTC
[GitHub] [flink] zentol opened a new pull request, #19593: [FLINK-27426][rpc] Migrate RPC system internals to Duration
zentol opened a new pull request, #19593:
URL: https://github.com/apache/flink/pull/19593
Based on #19592.
Migrates the RPC system internals to use Duration instead of Time. The only exception is the special timeout handling for the RPC interfaces, which will be done alter (as that requires touching all the runtime components).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19593: [FLINK-27426][rpc] Migrate RPC system internals to Duration
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19593:
URL: https://github.com/apache/flink/pull/19593#issuecomment-1110869592
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34a888b6156e45e01fb2de270d16c3dcb67ff581",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "34a888b6156e45e01fb2de270d16c3dcb67ff581",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 34a888b6156e45e01fb2de270d16c3dcb67ff581 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on a diff in pull request #19593: [FLINK-27426][rpc] Migrate RPC system internals to Duration
Posted by GitBox <gi...@apache.org>.
XComp commented on code in PR #19593:
URL: https://github.com/apache/flink/pull/19593#discussion_r860583562
##########
flink-runtime/src/test/java/org/apache/flink/runtime/rpc/RpcEndpointTest.java:
##########
@@ -51,7 +50,7 @@
@ExtendWith(TestLoggerExtension.class)
public class RpcEndpointTest {
- private static final Time TIMEOUT = Time.seconds(10L);
+ private static final Duration TIMEOUT = Duration.ofSeconds(10L);
Review Comment:
This one is only used in a single test. I think, we could move the timeout there...
##########
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/TestingDispatcher.java:
##########
@@ -159,12 +160,14 @@ void completeJobExecution(ExecutionGraphInfo executionGraphInfo) {
}
CompletableFuture<Void> getJobTerminationFuture(@Nonnull JobID jobId, @Nonnull Time timeout) {
Review Comment:
What about using `Duration` here and in `getNumberJobs` as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #19593: [FLINK-27426][rpc] Migrate RPC system internals to Duration
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #19593:
URL: https://github.com/apache/flink/pull/19593#discussion_r860617795
##########
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/TestingDispatcher.java:
##########
@@ -159,12 +160,14 @@ void completeJobExecution(ExecutionGraphInfo executionGraphInfo) {
}
CompletableFuture<Void> getJobTerminationFuture(@Nonnull JobID jobId, @Nonnull Time timeout) {
Review Comment:
Eventually. I want to go through things component-by-component, and this belongs to the dispatcher.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #19593: [FLINK-27426][rpc] Migrate RPC system internals to Duration
Posted by GitBox <gi...@apache.org>.
zentol merged PR #19593:
URL: https://github.com/apache/flink/pull/19593
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org