[GitHub] [datasketches-java] AlexanderSaydakov commented on a diff in pull request #419: throwing exceptions instead of returning null or Nan when sketch is empty.

[GitBox <gi...@apache.org>]

AlexanderSaydakov commented on code in PR #419:
URL: https://github.com/apache/datasketches-java/pull/419#discussion_r1001082990


##########
src/main/java/org/apache/datasketches/quantiles/HeapCompactDoublesSketch.java:
##########
@@ -50,22 +51,22 @@ final class HeapCompactDoublesSketch extends CompactDoublesSketch {
   static final int MIN_HEAP_DOUBLES_SER_VER = 1;
 
   /**
-   * The smallest quantile ever seen in the stream.
+   * The smallest item ever seen in the stream.
    */
-  private double minQuantile_;
+  private double minItem_;
 
   /**
-   * The largest quantile ever seen in the stream.
+   * The largest item ever seen in the stream.
    */
-  private double maxQuantile_;
+  private double maxItem_;
 
   /**
    * The total count of items seen.
    */
   private long n_;
 
   /**
-   * Number of quantiles currently in base buffer.
+   * Number of item currently in base buffer.

Review Comment:
   should be items



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org