You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by minahlee <gi...@git.apache.org> on 2017/01/05 12:56:09 UTC
[GitHub] zeppelin pull request #1850: [ZEPPELIN-1731] Fix unexpected EditOnDoubleClic...
GitHub user minahlee opened a pull request:
https://github.com/apache/zeppelin/pull/1850
[ZEPPELIN-1731] Fix unexpected EditOnDoubleClick
### What is this PR for?
This PR fixes wrong `EditOnDoubleClick` value in editor setting when default bound interpreter has changed.
### What type of PR is it?
Bug Fix
### Todos
* [ ] - Task
### What is the Jira issue?
[ZEPPELIN-1731](https://issues.apache.org/jira/browse/ZEPPELIN-1731)
### How should this be tested?
1. Set default interpreter to `md`.
2. Write below code in first paragraph and execute the paragraph. The editor should be hidden when you run.
```
## abc
pwd
```
3. Double click the result to make editor to be shown.
4. Change default interpreter to `sh`. At this point syntax highlight on `## abc` should be changed from blue to green.
5. Execute paragraph and see if editor stays displayed.
### Screenshots (if appropriate)
**Before**
**After**
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/minahlee/zeppelin ZEPPELIN-1731
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1850.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1850
----
commit 6e627088b94325efeaebe21dacf421ea26bd0997
Author: Mina Lee <mi...@apache.org>
Date: 2017-01-05T12:18:43Z
Fix unexpected EditOnDoubleClick
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1850: [ZEPPELIN-1731] Fix unexpected EditOnDoubleClic...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1850
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---