[GitHub] [skywalking] BFergerson commented on a diff in pull request #9446: Add an explanation doc for alerting kernel mechanism

[GitBox <gi...@apache.org>]

BFergerson commented on code in PR #9446:
URL: https://github.com/apache/skywalking/pull/9446#discussion_r941145344


##########
docs/en/setup/backend/backend-alarm.md:
##########
@@ -47,6 +50,17 @@ For example, in **percentile**, `value1` is the threshold of P50, and `-, -, val
 - **Silence period**. After the alarm is triggered at Time-N (TN), there will be silence during the **TN -> TN + period**.
 By default, it works in the same manner as **period**. The same Alarm (having the same ID in the same metrics name) may only be triggered once within a period. 
 
+Such as for a metric, there is a shifting window as following at T7.
+
+| T1     | T2     | T3     | T4     | T5     | T6     | T7     |
+|--------|--------|--------|--------|--------|--------|--------|
+| Value1 | Value2 | Value3 | Value4 | Value5 | Value6 | Value7 |
+
+* `Period`(Time point T1 ~ T7) are continuous data points for minutes. Notice, alerting doesn't support for hours/days metrics as pointless.

Review Comment:
   The wording here is a bit odd. Specifically: `Notice, alerting doesn't support for hours/days metrics as pointless.`.
   
   Maybe something like:
   
   ```suggestion
   * `Period`(Time point T1 ~ T7) are continuous data points for minutes. Notice, alerts are not supported above minute-by-minute periods as these would not be efficient.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org