You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2023/06/07 22:54:41 UTC

[commons-fileupload] 01/01: Clean up POMs and remove checkstyle Eclipse files

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch clean_up_poms_and_ignores
in repository https://gitbox.apache.org/repos/asf/commons-fileupload.git

commit 86cce7d58bfcab1f8a7603fb9bf53a415ebac95c
Author: Gary Gregory <gg...@rocketsoftware.com>
AuthorDate: Wed Jun 7 18:53:37 2023 -0400

    Clean up POMs and remove checkstyle Eclipse files
---
 .gitignore                              |  1 +
 commons-fileupload2-core/.checkstyle    | 15 ---------------
 commons-fileupload2-core/pom.xml        |  2 --
 commons-fileupload2-jakarta/.checkstyle | 15 ---------------
 commons-fileupload2-jakarta/pom.xml     |  2 --
 commons-fileupload2-javax/.checkstyle   | 15 ---------------
 commons-fileupload2-javax/pom.xml       |  1 -
 commons-fileupload2-portlet/.checkstyle | 15 ---------------
 pom.xml                                 | 21 +++++++++++++++++++++
 9 files changed, 22 insertions(+), 65 deletions(-)

diff --git a/.gitignore b/.gitignore
index 9e8811e..46bd3f3 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,4 +1,5 @@
 **/target/
+**/.checkstyle
 **/.settings/
 **/.classpath
 **/.project
diff --git a/commons-fileupload2-core/.checkstyle b/commons-fileupload2-core/.checkstyle
deleted file mode 100644
index 322b565..0000000
--- a/commons-fileupload2-core/.checkstyle
+++ /dev/null
@@ -1,15 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-
-<fileset-config file-format-version="1.2.0" simple-config="false" sync-formatter="false">
-  <local-check-config name="maven-checkstyle-plugin validate-main" location="file:/C:/Users/ggregory/git/a/commons-fileupload/commons-fileupload2-core/../src/checkstyle/fileupload_checks.xml" type="remote" description="maven-checkstyle-plugin configuration validate-main">
-    <property name="checkstyle.header.file" value="C:\Users\ggregory\OneDrive - Rocket Software, Inc\ew\apache-commons\.metadata\.plugins\org.eclipse.core.resources\.projects\commons-fileupload2-core\com.basistech.m2e.code.quality.checkstyleConfigurator\checkstyle-header-validate-main.txt"/>
-    <property name="checkstyle.cache.file" value="${project_loc}/target/checkstyle-cachefile"/>
-    <property name="checkstyle.suppressions.file" value="C:\Users\ggregory\OneDrive - Rocket Software, Inc\ew\apache-commons\.metadata\.plugins\org.eclipse.core.resources\.projects\commons-fileupload2-core\com.basistech.m2e.code.quality.checkstyleConfigurator\checkstyle-suppressions-validate-main.xml"/>
-  </local-check-config>
-  <fileset name="java-sources-validate-main" enabled="true" check-config-name="maven-checkstyle-plugin validate-main" local="true">
-    <file-match-pattern match-pattern="^src/main/java/.*\.java" include-pattern="true"/>
-    <file-match-pattern match-pattern="^src/main/resources.*\.properties" include-pattern="true"/>
-    <file-match-pattern match-pattern="^.*\.properties" include-pattern="true"/>
-    <file-match-pattern match-pattern="^src/test/resources.*\.properties" include-pattern="true"/>
-  </fileset>
-</fileset-config>
diff --git a/commons-fileupload2-core/pom.xml b/commons-fileupload2-core/pom.xml
index 21d8b0c..721b66f 100644
--- a/commons-fileupload2-core/pom.xml
+++ b/commons-fileupload2-core/pom.xml
@@ -45,12 +45,10 @@
     <dependency>
       <groupId>commons-io</groupId>
       <artifactId>commons-io</artifactId>
-      <version>${commons.io.version}</version>
     </dependency>
     <dependency>
       <groupId>org.apache.commons</groupId>
       <artifactId>commons-lang3</artifactId>
-      <version>${commons.lang3.version}</version>
       <scope>test</scope>
     </dependency>
   </dependencies>
diff --git a/commons-fileupload2-jakarta/.checkstyle b/commons-fileupload2-jakarta/.checkstyle
deleted file mode 100644
index e0d8bb7..0000000
--- a/commons-fileupload2-jakarta/.checkstyle
+++ /dev/null
@@ -1,15 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-
-<fileset-config file-format-version="1.2.0" simple-config="false" sync-formatter="false">
-  <local-check-config name="maven-checkstyle-plugin validate-main" location="file:/C:/Users/ggregory/git/a/commons-fileupload/commons-fileupload2-jakarta/../src/checkstyle/fileupload_checks.xml" type="remote" description="maven-checkstyle-plugin configuration validate-main">
-    <property name="checkstyle.header.file" value="C:\Users\ggregory\OneDrive - Rocket Software, Inc\ew\apache-commons\.metadata\.plugins\org.eclipse.core.resources\.projects\commons-fileupload2-jakarta\com.basistech.m2e.code.quality.checkstyleConfigurator\checkstyle-header-validate-main.txt"/>
-    <property name="checkstyle.cache.file" value="${project_loc}/target/checkstyle-cachefile"/>
-    <property name="checkstyle.suppressions.file" value="C:\Users\ggregory\OneDrive - Rocket Software, Inc\ew\apache-commons\.metadata\.plugins\org.eclipse.core.resources\.projects\commons-fileupload2-jakarta\com.basistech.m2e.code.quality.checkstyleConfigurator\checkstyle-suppressions-validate-main.xml"/>
-  </local-check-config>
-  <fileset name="java-sources-validate-main" enabled="true" check-config-name="maven-checkstyle-plugin validate-main" local="true">
-    <file-match-pattern match-pattern="^src/main/java/.*\.java" include-pattern="true"/>
-    <file-match-pattern match-pattern="^src/main/resources.*\.properties" include-pattern="true"/>
-    <file-match-pattern match-pattern="^.*\.properties" include-pattern="true"/>
-    <file-match-pattern match-pattern="^src/test/resources.*\.properties" include-pattern="true"/>
-  </fileset>
-</fileset-config>
diff --git a/commons-fileupload2-jakarta/pom.xml b/commons-fileupload2-jakarta/pom.xml
index 3f62577..cd09c51 100644
--- a/commons-fileupload2-jakarta/pom.xml
+++ b/commons-fileupload2-jakarta/pom.xml
@@ -56,7 +56,6 @@
     <dependency>
       <groupId>commons-io</groupId>
       <artifactId>commons-io</artifactId>
-      <version>${commons.io.version}</version>
     </dependency>
     <dependency>
       <groupId>jakarta.servlet</groupId>
@@ -68,7 +67,6 @@
     <dependency>
       <groupId>org.apache.commons</groupId>
       <artifactId>commons-lang3</artifactId>
-      <version>${commons.lang3.version}</version>
       <scope>test</scope>
     </dependency>
   </dependencies>
diff --git a/commons-fileupload2-javax/.checkstyle b/commons-fileupload2-javax/.checkstyle
deleted file mode 100644
index 192ffcc..0000000
--- a/commons-fileupload2-javax/.checkstyle
+++ /dev/null
@@ -1,15 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-
-<fileset-config file-format-version="1.2.0" simple-config="false" sync-formatter="false">
-  <local-check-config name="maven-checkstyle-plugin validate-main" location="file:/C:/Users/ggregory/git/a/commons-fileupload/commons-fileupload2-javax/../src/checkstyle/fileupload_checks.xml" type="remote" description="maven-checkstyle-plugin configuration validate-main">
-    <property name="checkstyle.header.file" value="C:\Users\ggregory\OneDrive - Rocket Software, Inc\ew\apache-commons\.metadata\.plugins\org.eclipse.core.resources\.projects\commons-fileupload2-javax\com.basistech.m2e.code.quality.checkstyleConfigurator\checkstyle-header-validate-main.txt"/>
-    <property name="checkstyle.cache.file" value="${project_loc}/target/checkstyle-cachefile"/>
-    <property name="checkstyle.suppressions.file" value="C:\Users\ggregory\OneDrive - Rocket Software, Inc\ew\apache-commons\.metadata\.plugins\org.eclipse.core.resources\.projects\commons-fileupload2-javax\com.basistech.m2e.code.quality.checkstyleConfigurator\checkstyle-suppressions-validate-main.xml"/>
-  </local-check-config>
-  <fileset name="java-sources-validate-main" enabled="true" check-config-name="maven-checkstyle-plugin validate-main" local="true">
-    <file-match-pattern match-pattern="^src/main/java/.*\.java" include-pattern="true"/>
-    <file-match-pattern match-pattern="^src/main/resources.*\.properties" include-pattern="true"/>
-    <file-match-pattern match-pattern="^.*\.properties" include-pattern="true"/>
-    <file-match-pattern match-pattern="^src/test/resources.*\.properties" include-pattern="true"/>
-  </fileset>
-</fileset-config>
diff --git a/commons-fileupload2-javax/pom.xml b/commons-fileupload2-javax/pom.xml
index ba44e85..5e680a6 100644
--- a/commons-fileupload2-javax/pom.xml
+++ b/commons-fileupload2-javax/pom.xml
@@ -62,7 +62,6 @@
     <dependency>
       <groupId>commons-io</groupId>
       <artifactId>commons-io</artifactId>
-      <version>${commons.io.version}</version>
     </dependency>
   </dependencies>
 
diff --git a/commons-fileupload2-portlet/.checkstyle b/commons-fileupload2-portlet/.checkstyle
deleted file mode 100644
index b97f1a3..0000000
--- a/commons-fileupload2-portlet/.checkstyle
+++ /dev/null
@@ -1,15 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-
-<fileset-config file-format-version="1.2.0" simple-config="false" sync-formatter="false">
-  <local-check-config name="maven-checkstyle-plugin validate-main" location="file:/C:/Users/ggregory/git/a/commons-fileupload/commons-fileupload2-portlet/../src/checkstyle/fileupload_checks.xml" type="remote" description="maven-checkstyle-plugin configuration validate-main">
-    <property name="checkstyle.header.file" value="C:\Users\ggregory\OneDrive - Rocket Software, Inc\ew\apache-commons\.metadata\.plugins\org.eclipse.core.resources\.projects\commons-fileupload2-portlet\com.basistech.m2e.code.quality.checkstyleConfigurator\checkstyle-header-validate-main.txt"/>
-    <property name="checkstyle.cache.file" value="${project_loc}/target/checkstyle-cachefile"/>
-    <property name="checkstyle.suppressions.file" value="C:\Users\ggregory\OneDrive - Rocket Software, Inc\ew\apache-commons\.metadata\.plugins\org.eclipse.core.resources\.projects\commons-fileupload2-portlet\com.basistech.m2e.code.quality.checkstyleConfigurator\checkstyle-suppressions-validate-main.xml"/>
-  </local-check-config>
-  <fileset name="java-sources-validate-main" enabled="true" check-config-name="maven-checkstyle-plugin validate-main" local="true">
-    <file-match-pattern match-pattern="^src/main/java/.*\.java" include-pattern="true"/>
-    <file-match-pattern match-pattern="^src/main/resources.*\.properties" include-pattern="true"/>
-    <file-match-pattern match-pattern="^.*\.properties" include-pattern="true"/>
-    <file-match-pattern match-pattern="^src/test/resources.*\.properties" include-pattern="true"/>
-  </fileset>
-</fileset-config>
diff --git a/pom.xml b/pom.xml
index fc1b77c..fa6e957 100644
--- a/pom.xml
+++ b/pom.xml
@@ -258,6 +258,27 @@
     <commons.releaseManagerKey>B6E73D84EA4FCC47166087253FAAD2CD5ECBB314</commons.releaseManagerKey>
   </properties>
 
+  <dependencyManagement>
+	<dependencies>
+      <dependency>
+        <groupId>org.junit.jupiter</groupId>
+        <artifactId>junit-jupiter</artifactId>
+        <version>${commons.junit.version}</version>
+        <scope>test</scope>
+      </dependency>
+      <dependency>
+        <groupId>commons-io</groupId>
+        <artifactId>commons-io</artifactId>
+        <version>${commons.io.version}</version>
+      </dependency>
+      <dependency>
+        <groupId>org.apache.commons</groupId>
+        <artifactId>commons-lang3</artifactId>
+        <version>${commons.lang3.version}</version>
+      </dependency>
+    </dependencies>
+  </dependencyManagement>
+
   <build>
     <plugins>
       <plugin>