You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/06 00:02:56 UTC

[GitHub] [kafka] vvcephei commented on a change in pull request #8819: MINOR: improve code encapsulation between StreamThread and TaskManager

vvcephei commented on a change in pull request #8819:
URL: https://github.com/apache/kafka/pull/8819#discussion_r436211217



##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##########
@@ -86,7 +87,7 @@
     private boolean rebalanceInProgress = false;  // if we are in the middle of a rebalance, it is not safe to commit
 
     // includes assigned & initialized tasks and unassigned tasks we locked temporarily during rebalance
-    private Set<TaskId> lockedTaskDirectories = new HashSet<>();
+    private final Set<TaskId> lockedTaskDirectories = new HashSet<>();

Review comment:
       Jinx! https://github.com/apache/kafka/pull/8818#discussion_r436193832




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org