[GitHub] vandanavk commented on a change in pull request #12878: ONNX export: Cleanup

[GitBox <gi...@apache.org>]

vandanavk commented on a change in pull request #12878: ONNX export: Cleanup
URL: https://github.com/apache/incubator-mxnet/pull/12878#discussion_r228677148
 
 

 ##########
 File path: python/mxnet/contrib/onnx/mx2onnx/_op_translations.py
 ##########
 @@ -219,18 +224,18 @@ def convert_fully_connected(node, **kwargs):
     """Map MXNet's FullyConnected operator attributes to onnx's Gemm operator
     and return the created node.
     """
-    onnx = import_onnx_modules()
-    name = node["name"]
-    inputs = node["inputs"]
-    attrs = node["attrs"]
+    onnx, name, proc_nodes, index_lookup, inputs, attrs = get_inputs(node, kwargs)
+
     initializer = kwargs["initializer"]
 
     no_bias = get_boolean_attribute_value(attrs, "no_bias")
 
-    input_node_id = kwargs["index_lookup"][inputs[0][0]]
-    weight_node_id = kwargs["index_lookup"][inputs[1][0]]
-
-    proc_nodes = kwargs["proc_nodes"]
+    input_node_id = index_lookup[inputs[0][0]]
 
 Review comment:
   Agree. Submitting a new version that cleans up how inputs are retrieved.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services