You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Laszlo Hornyak <la...@gmail.com> on 2013/09/28 18:38:48 UTC
Review Request 14398: NumbersUtil cleanup
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14398/
-----------------------------------------------------------
Review request for cloudstack.
Repository: cloudstack-git
Description
-------
- removed methods that were not used
- parseLong, parseInt and parseFloat replaced with the commons-lang NumberUtils call
- Test for the remaining methods
Diffs
-----
utils/src/com/cloud/utils/NumbersUtil.java 035239a
utils/test/com/cloud/utils/NumbersUtilTest.java f60f58a
Diff: https://reviews.apache.org/r/14398/diff/
Testing
-------
tests included
Thanks,
Laszlo Hornyak
Re: Review Request 14398: NumbersUtil cleanup
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14398/#review26462
-----------------------------------------------------------
Looks alright, please add spark404 to reviewers. just in case I missed something.
- daan Hoogland
On Sept. 28, 2013, 4:38 p.m., Laszlo Hornyak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14398/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2013, 4:38 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> - removed methods that were not used
> - parseLong, parseInt and parseFloat replaced with the commons-lang NumberUtils call
> - Test for the remaining methods
>
>
> Diffs
> -----
>
> utils/src/com/cloud/utils/NumbersUtil.java 035239a
> utils/test/com/cloud/utils/NumbersUtilTest.java f60f58a
>
> Diff: https://reviews.apache.org/r/14398/diff/
>
>
> Testing
> -------
>
> tests included
>
>
> Thanks,
>
> Laszlo Hornyak
>
>
Re: Review Request 14398: NumbersUtil cleanup
Posted by Hugo Trippaers <ht...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14398/#review26603
-----------------------------------------------------------
Ship it!
Ship It!
- Hugo Trippaers
On Sept. 29, 2013, 7:24 a.m., Laszlo Hornyak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14398/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2013, 7:24 a.m.)
>
>
> Review request for cloudstack, daan Hoogland and Hugo Trippaers.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> - removed methods that were not used
> - parseLong, parseInt and parseFloat replaced with the commons-lang NumberUtils call
> - Test for the remaining methods
>
>
> Diffs
> -----
>
> utils/src/com/cloud/utils/NumbersUtil.java 035239a
> utils/test/com/cloud/utils/NumbersUtilTest.java f60f58a
>
> Diff: https://reviews.apache.org/r/14398/diff/
>
>
> Testing
> -------
>
> tests included
>
>
> Thanks,
>
> Laszlo Hornyak
>
>
Re: Review Request 14398: NumbersUtil cleanup
Posted by Laszlo Hornyak <la...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14398/
-----------------------------------------------------------
(Updated Sept. 29, 2013, 7:24 a.m.)
Review request for cloudstack, daan Hoogland and Hugo Trippaers.
Repository: cloudstack-git
Description
-------
- removed methods that were not used
- parseLong, parseInt and parseFloat replaced with the commons-lang NumberUtils call
- Test for the remaining methods
Diffs
-----
utils/src/com/cloud/utils/NumbersUtil.java 035239a
utils/test/com/cloud/utils/NumbersUtilTest.java f60f58a
Diff: https://reviews.apache.org/r/14398/diff/
Testing
-------
tests included
Thanks,
Laszlo Hornyak