You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/01/30 09:37:13 UTC
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #39802: [SPARK-42237][SQL] Change binary to unsupported dataType in csv format
HyukjinKwon commented on code in PR #39802:
URL: https://github.com/apache/spark/pull/39802#discussion_r1090375965
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVFileFormat.scala:
##########
@@ -145,6 +145,8 @@ class CSVFileFormat extends TextBasedFileFormat with DataSourceRegister {
override def equals(other: Any): Boolean = other.isInstanceOf[CSVFileFormat]
override def supportDataType(dataType: DataType): Boolean = dataType match {
+ case _: BinaryType => false
Review Comment:
Did it work before? Disabling it makes sense at a glance but would be great if we can elabourate the reason behind so make sure it doesn't mistakenly break a reasonable workload that worked before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org