You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "yugvajani (via GitHub)" <gi...@apache.org> on 2024/12/16 01:46:49 UTC

Re: [PR] Fixed the non deterministic test testSerdeWithInputFormat (druid)

yugvajani commented on PR #17325:
URL: https://github.com/apache/druid/pull/17325#issuecomment-2544314507

   Initially, I had resolved the issue by sorting the contents of the JSON. However, since the ordering of elements is important, I later updated the solution to align with how other tests handled ordering. The parser we were using provided a deterministic order, which ensured the test passed.
   
   Now that the parser is deprecated, one possible solution could be to avoid relying on string equality for comparisons and instead perform a direct JSON comparison. What is your opinion on this one?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org