[GitHub] [storm] kishorvpatil commented on a change in pull request #3217: STORM-3590: Adds test to validate that GRAS's node sort is stable and…

[GitBox <gi...@apache.org>]

kishorvpatil commented on a change in pull request #3217: STORM-3590: Adds test to validate that GRAS's node sort is stable and…
URL: https://github.com/apache/storm/pull/3217#discussion_r387720778
 
 

 ##########
 File path: storm-server/src/main/java/org/apache/storm/scheduler/Topologies.java
 ##########
 @@ -76,6 +76,14 @@ public Topologies(Topologies src) {
         return ret;
     }
 
+    public void addTopology(TopologyDetails details) {
 
 Review comment:
   This is supposed to be immutable class. just create another instance of topologies using constructor. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services