[GitHub] [storm] jmpoholarz commented on a change in pull request #3385: Add Metrics for Trident Kafka Spout/Emitter

[GitBox <gi...@apache.org>]

jmpoholarz commented on a change in pull request #3385:
URL: https://github.com/apache/storm/pull/3385#discussion_r597997026



##########
File path: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/trident/KafkaTridentSpoutEmitter.java
##########
@@ -60,6 +65,14 @@
     private static final long serialVersionUID = -7343927794834130435L;
     private static final Logger LOG = LoggerFactory.getLogger(KafkaTridentSpoutEmitter.class);
 
+    // Metrics
+    public static final String UNDERSCORE = "_";
+    public static final String INTERNAL_KAFKA_RECORDS_LAG_MAX_METRIC = "records-lag-max";
+    public static final String KAFKA_CLIENT_MAX_LAG_METRIC_NAME = "kafkaClientMaxLag";
+    protected transient Gauge<Double> kafkaClientMaxLag;
+    public static final String EVENT_EMIT_METRIC_NAME = "eventEmitRate";
+    protected transient Meter eventEmitRate;

Review comment:
       This builtin might be sufficient.  Our metric names seem to be reporting values like `__emit-count-s1` or `__emit-count-s2` (there are almost 200 of these on our Yamas metric search, I'm guessing one per stream).  Perhaps something is mis-configured in our topologies preventing it from extracting useful stream names.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org