[GitHub] [spark] HeartSaVioR edited a comment on issue #24613: [SPARK-27549][SS] Add support for committing kafka offsets per batch for supporting external tooling

[GitBox <gi...@apache.org>]

HeartSaVioR edited a comment on issue #24613: [SPARK-27549][SS] Add support for committing kafka offsets per batch for supporting external tooling
URL: https://github.com/apache/spark/pull/24613#issuecomment-494257881
 
 
   >> query ID might be considered as unique group id since it can provide both unique and continuous, but it should consider the case where multiple Kafka sources are being used in same query.
   
   > In that case we could have an increasing id added as sources are getting registered, assuming code is not modified keeping registration order the same on restart.
   
   The approach sounds viable to me, but the origin idea was started from my side so I don't feel I'm right one to validate the option.
   
   EDIT: This case might be still an issue even if query ID is being used as consumer ID - `This may also occur when queries are started/restarted in quick succession.`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org