You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jdo-dev@db.apache.org by "Matthew T. Adams (JIRA)" <ji...@apache.org> on 2005/09/22 18:18:37 UTC
[jira] Created: (JDO-146) PM & PMF missing property detachAllOnCommit
PM & PMF missing property detachAllOnCommit
-------------------------------------------
Key: JDO-146
URL: http://issues.apache.org/jira/browse/JDO-146
Project: JDO
Type: Bug
Components: api20
Reporter: Matthew T. Adams
Assigned to: Matthew T. Adams
The api20 interfaces PersistenceManager and PersistenceManagerFactory are missing the spec-defined boolean property detachAllOnCommit.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (JDO-146) PM & PMF missing property detachAllOnCommit
Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-146?page=comments#action_12330210 ]
Craig Russell commented on JDO-146:
-----------------------------------
The runtime20 classes that implement PersistenceManager and PersistenceManagerFactory also need to be updated so they compile.
For now, I think adding a flag to the PMF and PM implementations is easy. But if the user commits with the DetachAllOnCommit flag true, an exception needs to be thrown.
> PM & PMF missing property detachAllOnCommit
> -------------------------------------------
>
> Key: JDO-146
> URL: http://issues.apache.org/jira/browse/JDO-146
> Project: JDO
> Type: Bug
> Components: api20
> Reporter: Matthew T. Adams
> Assignee: Matthew T. Adams
> Attachments: detachOnAllCommit.patch
>
> The api20 interfaces PersistenceManager and PersistenceManagerFactory are missing the spec-defined boolean property detachAllOnCommit.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (JDO-146) PM & PMF missing property detachAllOnCommit
Posted by "Matthew T. Adams (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-146?page=all ]
Matthew T. Adams resolved JDO-146:
----------------------------------
Resolution: Fixed
Bombs away! Committed changes to api20, runtime20, and tck20.
> PM & PMF missing property detachAllOnCommit
> -------------------------------------------
>
> Key: JDO-146
> URL: http://issues.apache.org/jira/browse/JDO-146
> Project: JDO
> Type: Bug
> Components: api20
> Reporter: Matthew T. Adams
> Assignee: Matthew T. Adams
> Attachments: detachOnAllCommit.api20.patch, detachOnAllCommit.patch, detachOnAllCommit.runtime20.patch
>
> The api20 interfaces PersistenceManager and PersistenceManagerFactory are missing the spec-defined boolean property detachAllOnCommit.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (JDO-146) PM & PMF missing property detachAllOnCommit
Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-146?page=comments#action_12330211 ]
Craig Russell commented on JDO-146:
-----------------------------------
And not to forget PersistenceManagerWrapper that also implements the PM interface.
> PM & PMF missing property detachAllOnCommit
> -------------------------------------------
>
> Key: JDO-146
> URL: http://issues.apache.org/jira/browse/JDO-146
> Project: JDO
> Type: Bug
> Components: api20
> Reporter: Matthew T. Adams
> Assignee: Matthew T. Adams
> Attachments: detachOnAllCommit.patch
>
> The api20 interfaces PersistenceManager and PersistenceManagerFactory are missing the spec-defined boolean property detachAllOnCommit.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (JDO-146) PM & PMF missing property detachAllOnCommit
Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-146?page=comments#action_12330441 ]
Craig Russell commented on JDO-146:
-----------------------------------
This is a temporary exception, as it's not an option for a compliant JDO 2 implementation.
Other JDO 2 methods that are not currently supported throw UnsupportedOperationException.
Take a look at PersistenceManagerImpl.getObjectsById(Collection).
For consistency, this is the pattern we should adopt. We will at some time remove all these exceptions...
> PM & PMF missing property detachAllOnCommit
> -------------------------------------------
>
> Key: JDO-146
> URL: http://issues.apache.org/jira/browse/JDO-146
> Project: JDO
> Type: Bug
> Components: api20
> Reporter: Matthew T. Adams
> Assignee: Matthew T. Adams
> Attachments: detachOnAllCommit.api20.patch, detachOnAllCommit.patch, detachOnAllCommit.runtime20.patch
>
> The api20 interfaces PersistenceManager and PersistenceManagerFactory are missing the spec-defined boolean property detachAllOnCommit.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (JDO-146) PM & PMF missing property detachAllOnCommit
Posted by "Matthew T. Adams (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-146?page=all ]
Matthew T. Adams updated JDO-146:
---------------------------------
Attachment: detachOnAllCommit.api20.patch
This patch supercedes the patch called "detachAllOnCommit.patch".
> PM & PMF missing property detachAllOnCommit
> -------------------------------------------
>
> Key: JDO-146
> URL: http://issues.apache.org/jira/browse/JDO-146
> Project: JDO
> Type: Bug
> Components: api20
> Reporter: Matthew T. Adams
> Assignee: Matthew T. Adams
> Attachments: detachOnAllCommit.api20.patch, detachOnAllCommit.patch, detachOnAllCommit.runtime20.patch
>
> The api20 interfaces PersistenceManager and PersistenceManagerFactory are missing the spec-defined boolean property detachAllOnCommit.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (JDO-146) PM & PMF missing property detachAllOnCommit
Posted by "Matthew T. Adams (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-146?page=comments#action_12330303 ]
Matthew T. Adams commented on JDO-146:
--------------------------------------
Which exception should be thrown by TransactionImpl.commit() and which message key should be given if DetachAllOnCommit is true? I'm currently planning to use JDOCanRetryException with message key "notsupported", even though the Bundle.properties file says "# XXX TBD: this message is not used:" above the definition of the key. Please advise if these are not appropriate.
> PM & PMF missing property detachAllOnCommit
> -------------------------------------------
>
> Key: JDO-146
> URL: http://issues.apache.org/jira/browse/JDO-146
> Project: JDO
> Type: Bug
> Components: api20
> Reporter: Matthew T. Adams
> Assignee: Matthew T. Adams
> Attachments: detachOnAllCommit.patch
>
> The api20 interfaces PersistenceManager and PersistenceManagerFactory are missing the spec-defined boolean property detachAllOnCommit.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (JDO-146) PM & PMF missing property detachAllOnCommit
Posted by "Matthew T. Adams (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-146?page=all ]
Matthew T. Adams updated JDO-146:
---------------------------------
Attachment: detachOnAllCommit.patch
Attaching patch to add missing property to PM & PMF
> PM & PMF missing property detachAllOnCommit
> -------------------------------------------
>
> Key: JDO-146
> URL: http://issues.apache.org/jira/browse/JDO-146
> Project: JDO
> Type: Bug
> Components: api20
> Reporter: Matthew T. Adams
> Assignee: Matthew T. Adams
> Attachments: detachOnAllCommit.patch
>
> The api20 interfaces PersistenceManager and PersistenceManagerFactory are missing the spec-defined boolean property detachAllOnCommit.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (JDO-146) PM & PMF missing property detachAllOnCommit
Posted by "Matthew T. Adams (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-146?page=all ]
Matthew T. Adams updated JDO-146:
---------------------------------
Attachment: detachOnAllCommit.runtime20.patch
These are my proposed changes to runtime20. In particular, please double-check TransactionImpl.commit(), where I've added an exception if the associated PersistenceManager's detachAllOnCommit property is true, as per Craig's earlier suggestion.
> PM & PMF missing property detachAllOnCommit
> -------------------------------------------
>
> Key: JDO-146
> URL: http://issues.apache.org/jira/browse/JDO-146
> Project: JDO
> Type: Bug
> Components: api20
> Reporter: Matthew T. Adams
> Assignee: Matthew T. Adams
> Attachments: detachOnAllCommit.patch, detachOnAllCommit.runtime20.patch
>
> The api20 interfaces PersistenceManager and PersistenceManagerFactory are missing the spec-defined boolean property detachAllOnCommit.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira