RE: cvs commit: jakarta-turbine-stratum/src/java/org/apache/stratum/jcs/utils/threads ThreadPool.java

[James Taylor <jt...@4lane.com>]

On Fri, 2002-02-15 at 00:31, Aaron Smuts wrote:
> That was amazing!

=]

> Yes, almost everything is debug level trace logging.  The code would be
> far cleaner without much of it.  There may be some places where it will
> have to stay for a bit, primarily in the group cache.  The locking got
> to be a pain with the nested method calls.  I think I cleaned it up a
> bit a while back.

We should definitely remove redundant logging and things that can easily
be done with aspectj, but otherwise I have no problem with keeping a lot
of the debug level stuff in there. What I'd like to see is enough of it
pushed up to info that one can run at debug rather than info, and still
get a general idea of what is happening. 

> I guess you are much more familiar with the code now.  The commit email
> was half a MB.

Yeah. What helps a lot is understanding better how it is partitioned,
and what responsibilities the major packages have. We should probably
get some package level documentation in there, I think that would help
others a lot.

Thanks,
James


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

izombie

[Aaron Smuts <aa...@verizon.net>]

Izombie could go in org.apache.stratum.jcs.engine.behavior


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

RE: attributes

[Aaron Smuts <aa...@verizon.net>]

It bugs me too.  I just never did it and still haven't.  It got that way
because of the jcache api, which I don't care that much about anymore.

Aaron

> -----Original Message-----
> From: James Taylor [mailto:jtaylor@4lane.com]
> Sent: Saturday, February 16, 2002 5:07 PM
> To: 'Turbine Developers List'
> Subject: Re: attributes
> 
> +1 (billion if I could, that's been buggin me for a while =)
> 
> -- jt
> 
> On Sat, 2002-02-16 at 17:10, Aaron Smuts wrote:
> >
> >
> > There is a confusing naming convention in the cache. Attributes is
for
> > elements and cache attributes is for CacheAttributes.  I think
> > Attributes should become ElementAttributes and all the methods
around
> > element attributes should have the word element in the method name.
> >
> >
> > --
> > To unsubscribe, e-mail:   <mailto:turbine-dev-
> unsubscribe@jakarta.apache.org>
> > For additional commands, e-mail: <mailto:turbine-dev-
> help@jakarta.apache.org>
> >
> >
> 
> 
> 
> --
> To unsubscribe, e-mail:   <mailto:turbine-dev-
> unsubscribe@jakarta.apache.org>
> For additional commands, e-mail: <mailto:turbine-dev-
> help@jakarta.apache.org>


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

Re: attributes

[James Taylor <jt...@4lane.com>]

+1 (billion if I could, that's been buggin me for a while =)

-- jt

On Sat, 2002-02-16 at 17:10, Aaron Smuts wrote:
> 
> 
> There is a confusing naming convention in the cache. Attributes is for
> elements and cache attributes is for CacheAttributes.  I think
> Attributes should become ElementAttributes and all the methods around
> element attributes should have the word element in the method name.
> 
> 
> --
> To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
> 
> 



--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

attributes

[Aaron Smuts <aa...@verizon.net>]

There is a confusing naming convention in the cache. Attributes is for
elements and cache attributes is for CacheAttributes.  I think
Attributes should become ElementAttributes and all the methods around
element attributes should have the word element in the method name.


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>