You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/05/18 09:06:24 UTC

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #811: IGNITE-16999 Sql. Refactor IgniteBuiltInMethod and IgniteMethod classes

korlov42 commented on code in PR #811:
URL: https://github.com/apache/ignite-3/pull/811#discussion_r875655123


##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/AsyncRootNode.java:
##########
@@ -80,7 +80,7 @@
      *
      * @see #lastRow
      */
-    private boolean firstRequest = true;
+    private volatile boolean firstRequest = true;

Review Comment:
   do we really need this volatile?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org