[jira] [Commented] (FLINK-9660) Allow passing custom artifacts to Mesos workers

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-9660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16523155#comment-16523155 ] 

ASF GitHub Bot commented on FLINK-9660:
---------------------------------------

GitHub user lishim opened a pull request:

    https://github.com/apache/flink/pull/6207

    [FLINK-9660] [mesos] Allow passing custom artifacts to Mesos workers

    ## What is the purpose of the change
    
    * This pull request introduces a feature that allows passing custom artifact URIs to Mesos workers
    
    ## Brief change log
    
    * A new parameter ```mesos.resourcemanager.tasks.uris``` was introduced
    
    ## Verifying this change
    
    This change added tests and can be verified as follows:
    
      - Added unit tests that verify correctness of behavior of new parameter
      - Manually verified behavior by running Flink in Mesos with Docker containerizer and 2 task managers.  A private Docker registry was used for taskmanager Docker image.  Confirmed that Mesos was unable to pull the image with default settings.  After that, added ```mesos.resourcemanager.tasks.uris``` parameter with path to local archive containing Docker credentials configuration.  Confirmed the file was extracted to local sandbox of taskmanager Mesos task, and Docker image was successfully pulled.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): no
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
      - The serializers: no
      - The runtime per-record code paths (performance sensitive): no
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: yes
      - The S3 file system connector: no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? yes
      - If yes, how is the feature documented? docs


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lishim/flink master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6207.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6207
    
----
commit 2547f1b68e22da167bfa0264a72223fea3ed0d43
Author: Leonid Ishimnikov <li...@...>
Date:   2018-06-21T19:13:09Z

    [FLINK-9660] Allow passing custom artifacts to Mesos workers

----


> Allow passing custom artifacts to Mesos workers
> -----------------------------------------------
>
>                 Key: FLINK-9660
>                 URL: https://issues.apache.org/jira/browse/FLINK-9660
>             Project: Flink
>          Issue Type: Improvement
>          Components: Mesos
>            Reporter: Leonid Ishimnikov
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.6.0
>
>
> It would be nice to be able to pass custom artifact URIs to Mesos workers.  This is useful when an image from a private Docker repository is used for launching TaskManagers.  A URI for an archive containing login credentials can be provided in this case.  I propose adding a {{mesos.resourcemanager.tasks.uris}} parameter that will contain a comma-separated list of URIs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)