You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by darkyen <gi...@git.apache.org> on 2015/06/27 02:31:37 UTC
[GitHub] cordova-plugin-contacts pull request: Do not return absolute path ...
GitHub user darkyen opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/65
Do not return absolute path for contact images.
If an absolute url is returned the developer must use the file system api to get a reference to the image, instead returning a blob url makes more sense, and it seems more logical.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/darkyen/cordova-plugin-contacts patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-contacts/pull/65.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #65
----
commit 16942ffdcd725be763acb76d40dce91b518de7df
Author: Abhishek Hingnikar <ab...@hingnikar.com>
Date: 2015-06-27T00:29:41Z
Do not return absolute path for contact images.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: Do not return absolute path ...
Posted by darkyen <gi...@git.apache.org>.
Github user darkyen commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/65#issuecomment-116853635
Personally I feel that returning a blob url is probably going to be a better bet cross device, then a single format for images and other media can be followed, same as what browsers do.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: Do not return absolute path ...
Posted by JackStoneDev <gi...@git.apache.org>.
Github user JackStoneDev commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/65#issuecomment-132757235
What is the status on this? I'm having a hard time turning the photos returned on iOS into base64-encoded strings. How might I do that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: Do not return absolute path ...
Posted by cfjedimaster <gi...@git.apache.org>.
Github user cfjedimaster commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/65#issuecomment-116725065
Are you sure this is needed? I think you are wrong about needing to use the FileSystem API to convert the URLs. I had no issue using the URLs returned here:
http://www.raymondcamden.com/2014/12/23/cordova-demo-viewing-all-contacts
Also, a Blob URL would make the data returned by the API quite a bit larger and could have performance impacts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: Do not return absolute path ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-contacts/pull/65
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: Do not return absolute path ...
Posted by darkyen <gi...@git.apache.org>.
Github user darkyen commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/65#issuecomment-116785859
@cfjedimaster The platform you tested seems to be android, on windows phone you cannot directly use absolute paths (for obvious reasons).
Windows returns a file, get the absolute url out of the file, read it again(also messing up with path is quite hectic on wp) using windows api (which already gave u the file), whereas if we use blob urls they are the de-facto way to read media on filesystem, now the runtime itself manages the reading of the file, the user can store the file if they want.
Also a blob url is actually just a uuid, (its not data-url). Its actually smaller than the absolute file path on windows phone. ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: Do not return absolute path ...
Posted by cfjedimaster <gi...@git.apache.org>.
Github user cfjedimaster commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/65#issuecomment-116787903
Ah ok - so I misread it then.
On Mon, Jun 29, 2015 at 1:27 PM, Abhishek Hingnikar <
notifications@github.com> wrote:
> @cfjedimaster <https://github.com/cfjedimaster> The platform you tested
> seems to be android, on windows phone you cannot directly use absolute
> paths (for obvious reasons).
>
> Windows returns a file, get the absolute url out of the file, read it
> again(also messing up with path is quite hectic on wp) using windows api
> (which already gave u the file), whereas if we use blob urls they are the
> de-facto way to read media on filesystem, now the runtime itself manages
> the reading of the file, the user can store the file if they want.
>
> Also a blob url is actually just a uuid, (its not data-url). Its actually
> smaller than the absolute file path on windows phone. ;-)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cordova-plugin-contacts/pull/65#issuecomment-116785859>
> .
>
--
===========================================================================
Raymond Camden, Developer Advocate for MobileFirst at IBM
Email : raymondcamden@gmail.com
Blog : www.raymondcamden.com
Twitter: raymondcamden
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org