[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #2382: [ST-Engine][PhysicalPlan] Update PhysicalPlan to support scheduler by pipeline

[GitBox <gi...@apache.org>]

EricJoy2048 commented on code in PR #2382:
URL: https://github.com/apache/incubator-seatunnel/pull/2382#discussion_r941065329


##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/dag/physical/PhysicalPlan.java:
##########
@@ -17,38 +17,134 @@
 
 package org.apache.seatunnel.engine.server.dag.physical;
 
-import org.apache.seatunnel.engine.server.task.TaskGroupInfo;
+import org.apache.seatunnel.engine.common.utils.NonCompletableFuture;

Review Comment:
   > I have a little doubt, why put the scheduling-related logic directly in the physical plan, why not create a new class to do this?
   
   I refer to Flink, spark and other computing engines, which manage the job state in PyhsicalPlan. I understand that this is reasonable. The physical execution plan is not only used to represent a DAG relationship. The execution plan should be responsible for job execution and state manager.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org