You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/10/09 12:25:22 UTC

[GitHub] GJL commented on a change in pull request #6779: [FLINK-10465][tests] Do not stop sshd if it is supervised by runit.

GJL commented on a change in pull request #6779: [FLINK-10465][tests] Do not stop sshd if it is supervised by runit.
URL: https://github.com/apache/flink/pull/6779#discussion_r223677409
 
 

 ##########
 File path: flink-jepsen/src/jepsen/flink/utils.clj
 ##########
 @@ -86,4 +86,7 @@
   []
   (info "Stop all supervised services.")
   (c/su
-    (c/exec :rm :-f (c/lit (str "/etc/service/*")))))
+    ;; HACK:
+    ;; Remove all symlinks in /etc/service except sshd.
+    ;; This is only relevant when tests are run in Docker because there sshd is started using runit.
+    (c/exec :find (c/lit (str "/etc/service -maxdepth 1 -type l ! -name 'sshd' -delete")))))
 
 Review comment:
   I prefer to leave `-maxdepth` to avoid accidental recursive traversal. Without `-l` it tries to delete the directory.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services