You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by "stenio2011 (GitHub)" <gi...@apache.org> on 2019/03/08 07:56:54 UTC

[GitHub] [incubator-dubbo] stenio2011 opened issue #3623: about custom Exception which extends RuntimeException

interface project.
![image](https://user-images.githubusercontent.com/6884558/54014983-5148ee00-41b9-11e9-9e0a-3593d30f2e43.png)

interface class.
![image](https://user-images.githubusercontent.com/6884558/54015009-6160cd80-41b9-11e9-82d3-3b77a51dc38f.png)


provider implements class.
![image](https://user-images.githubusercontent.com/6884558/54015071-910fd580-41b9-11e9-9ff3-ae84cfb9a42c.png)

consumer class
![image](https://user-images.githubusercontent.com/6884558/54015095-a422a580-41b9-11e9-8c53-75dd2a273d2a.png)

In consumer class, I caught the DemoException, so I can consider it running correctly.
But why it logged error  in the provider progress?

Should the log line `logger.error(xxx)` move bellow the code bellow in ExceptionFilter.java ?
`// directly throw if it's dubbo exception
  if (exception instanceof RpcException) {
      return result;
  }`


[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3623 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] tswstarplanet commented on issue #3623: about custom Exception which extends RuntimeException

Posted by "tswstarplanet (GitHub)" <gi...@apache.org>.

RuntimeException is not predicted, maybe it is caused by a programming error, so dubbo does not know if the exception is throw by developer explicitly.

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3623 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] tswstarplanet commented on issue #3623: about custom Exception which extends RuntimeException

Posted by "tswstarplanet (GitHub)" <gi...@apache.org>.

And does a error log cause some problems ?

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3623 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org