You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/12/20 14:07:37 UTC
[GitHub] [airflow] nuclearpinguin opened a new pull request #6867:
[AIRFLOW-6315] Create .airflow_db_initialised always in tests dir
nuclearpinguin opened a new pull request #6867: [AIRFLOW-6315] Create .airflow_db_initialised always in tests dir
URL: https://github.com/apache/airflow/pull/6867
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-6315
### Description
- [ ] Here are some details about my PR, including screenshots of any UI changes:
I observed that directory where `. airflow_db_initialised` file is created depends on where is the test we run. The file is used by `breeze_test_helper` to keep information that db has been initialised.
This change will keep the file always in root directory fo tests.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain docstrings that explain what it does
- If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6867:
[AIRFLOW-6315] Create .airflow_db_initialised always in tests dir
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6867: [AIRFLOW-6315] Create .airflow_db_initialised always in tests dir
URL: https://github.com/apache/airflow/pull/6867#issuecomment-568268141
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=h1) Report
> Merging [#6867](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/072dab62c480fc04587e92db1174f319444d2bb6?src=pr&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6867 +/- ##
==========================================
- Coverage 84.39% 84.33% -0.06%
==========================================
Files 680 680
Lines 38501 38501
==========================================
- Hits 32491 32468 -23
- Misses 6010 6033 +23
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+0.28%)` | :arrow_up: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
| [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `77.6% <0%> (+1.52%)` | :arrow_up: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `96.61% <0%> (+6.77%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=footer). Last update [072dab6...081bced](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6867:
[AIRFLOW-6315] Create .airflow_db_initialised always in tests dir
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6867: [AIRFLOW-6315] Create .airflow_db_initialised always in tests dir
URL: https://github.com/apache/airflow/pull/6867#issuecomment-568268141
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=h1) Report
> Merging [#6867](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/072dab62c480fc04587e92db1174f319444d2bb6?src=pr&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6867 +/- ##
==========================================
- Coverage 84.39% 84.33% -0.06%
==========================================
Files 680 680
Lines 38501 38501
==========================================
- Hits 32491 32468 -23
- Misses 6010 6033 +23
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+0.28%)` | :arrow_up: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
| [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `77.6% <0%> (+1.52%)` | :arrow_up: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `96.61% <0%> (+6.77%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=footer). Last update [072dab6...081bced](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6867:
[AIRFLOW-6315] Create .airflow_db_initialised always in tests dir
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6867: [AIRFLOW-6315] Create .airflow_db_initialised always in tests dir
URL: https://github.com/apache/airflow/pull/6867#issuecomment-568268141
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=h1) Report
> Merging [#6867](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/072dab62c480fc04587e92db1174f319444d2bb6?src=pr&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6867 +/- ##
==========================================
- Coverage 84.39% 84.33% -0.06%
==========================================
Files 680 680
Lines 38501 38501
==========================================
- Hits 32491 32468 -23
- Misses 6010 6033 +23
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+0.28%)` | :arrow_up: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
| [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `77.6% <0%> (+1.52%)` | :arrow_up: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `96.61% <0%> (+6.77%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=footer). Last update [072dab6...081bced](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6867:
[AIRFLOW-6315] Create .airflow_db_initialised always in tests dir
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6867: [AIRFLOW-6315] Create .airflow_db_initialised always in tests dir
URL: https://github.com/apache/airflow/pull/6867#issuecomment-568268141
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=h1) Report
> Merging [#6867](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/072dab62c480fc04587e92db1174f319444d2bb6?src=pr&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6867 +/- ##
==========================================
- Coverage 84.39% 84.33% -0.06%
==========================================
Files 680 680
Lines 38501 38501
==========================================
- Hits 32491 32468 -23
- Misses 6010 6033 +23
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+0.28%)` | :arrow_up: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
| [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `77.6% <0%> (+1.52%)` | :arrow_up: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `96.61% <0%> (+6.77%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=footer). Last update [072dab6...081bced](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] nuclearpinguin merged pull request #6867: [AIRFLOW-6315]
Create .airflow_db_initialised always in tests dir
Posted by GitBox <gi...@apache.org>.
nuclearpinguin merged pull request #6867: [AIRFLOW-6315] Create .airflow_db_initialised always in tests dir
URL: https://github.com/apache/airflow/pull/6867
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6867:
[AIRFLOW-6315] Create .airflow_db_initialised always in tests dir
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6867: [AIRFLOW-6315] Create .airflow_db_initialised always in tests dir
URL: https://github.com/apache/airflow/pull/6867#issuecomment-568268141
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=h1) Report
> Merging [#6867](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/072dab62c480fc04587e92db1174f319444d2bb6?src=pr&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6867 +/- ##
==========================================
- Coverage 84.39% 84.33% -0.06%
==========================================
Files 680 680
Lines 38501 38501
==========================================
- Hits 32491 32468 -23
- Misses 6010 6033 +23
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+0.28%)` | :arrow_up: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
| [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `77.6% <0%> (+1.52%)` | :arrow_up: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `96.61% <0%> (+6.77%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=footer). Last update [072dab6...081bced](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #6867: [AIRFLOW-6315]
Create .airflow_db_initialised always in tests dir
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #6867: [AIRFLOW-6315] Create .airflow_db_initialised always in tests dir
URL: https://github.com/apache/airflow/pull/6867#issuecomment-568268141
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=h1) Report
> Merging [#6867](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/072dab62c480fc04587e92db1174f319444d2bb6?src=pr&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6867 +/- ##
==========================================
- Coverage 84.39% 84.33% -0.06%
==========================================
Files 680 680
Lines 38501 38501
==========================================
- Hits 32491 32468 -23
- Misses 6010 6033 +23
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+0.28%)` | :arrow_up: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
| [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `77.6% <0%> (+1.52%)` | :arrow_up: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `96.61% <0%> (+6.77%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=footer). Last update [072dab6...081bced](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6867:
[AIRFLOW-6315] Create .airflow_db_initialised always in tests dir
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6867: [AIRFLOW-6315] Create .airflow_db_initialised always in tests dir
URL: https://github.com/apache/airflow/pull/6867#issuecomment-568268141
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=h1) Report
> Merging [#6867](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/072dab62c480fc04587e92db1174f319444d2bb6?src=pr&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6867 +/- ##
==========================================
- Coverage 84.39% 84.33% -0.06%
==========================================
Files 680 680
Lines 38501 38501
==========================================
- Hits 32491 32468 -23
- Misses 6010 6033 +23
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+0.28%)` | :arrow_up: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
| [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `77.6% <0%> (+1.52%)` | :arrow_up: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `96.61% <0%> (+6.77%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=footer). Last update [072dab6...081bced](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6867:
[AIRFLOW-6315] Create .airflow_db_initialised always in tests dir
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6867: [AIRFLOW-6315] Create .airflow_db_initialised always in tests dir
URL: https://github.com/apache/airflow/pull/6867#issuecomment-568268141
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=h1) Report
> Merging [#6867](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/072dab62c480fc04587e92db1174f319444d2bb6?src=pr&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6867 +/- ##
==========================================
- Coverage 84.39% 84.33% -0.06%
==========================================
Files 680 680
Lines 38501 38501
==========================================
- Hits 32491 32468 -23
- Misses 6010 6033 +23
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+0.28%)` | :arrow_up: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
| [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `77.6% <0%> (+1.52%)` | :arrow_up: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `96.61% <0%> (+6.77%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=footer). Last update [072dab6...081bced](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6867:
[AIRFLOW-6315] Create .airflow_db_initialised always in tests dir
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6867: [AIRFLOW-6315] Create .airflow_db_initialised always in tests dir
URL: https://github.com/apache/airflow/pull/6867#issuecomment-568268141
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=h1) Report
> Merging [#6867](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/072dab62c480fc04587e92db1174f319444d2bb6?src=pr&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6867 +/- ##
==========================================
- Coverage 84.39% 84.33% -0.06%
==========================================
Files 680 680
Lines 38501 38501
==========================================
- Hits 32491 32468 -23
- Misses 6010 6033 +23
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+0.28%)` | :arrow_up: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
| [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `77.6% <0%> (+1.52%)` | :arrow_up: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `96.61% <0%> (+6.77%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=footer). Last update [072dab6...081bced](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk edited a comment on issue #6867: [AIRFLOW-6315]
Create .airflow_db_initialised always in tests dir
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #6867: [AIRFLOW-6315] Create .airflow_db_initialised always in tests dir
URL: https://github.com/apache/airflow/pull/6867#issuecomment-568074992
I think it's more to that. We should not create it in the test folder because it is shared between host and container. So rather than removing it in the "entrypoint" I'd crate it in ${AIRFLOW_HOME} (fallback to ${HOME}/airflow if AIRFLOW_HOME is not defined. This is easy to create and has the benefit that if you exit the container, it will be gone. Also you can run several containers in parallel this way with independently initialized database.
Also this way, if you ran tests in the HOST it will initialise database independently from the container.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #6867: [AIRFLOW-6315] Create
.airflow_db_initialised always in tests dir
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #6867: [AIRFLOW-6315] Create .airflow_db_initialised always in tests dir
URL: https://github.com/apache/airflow/pull/6867#issuecomment-568074992
I think it's more to that. We should not create it in the test folder because it is shared between host and container. So rather than removing it in the "entrypoint" I'd crate it in ${AIRFLOW_HOME} (fallback to ${HOME}/airflow if AIRFLOW_HOME is not defined. This is easy to create and has the benefit that if you exit the container, it will be gone. Also you can run several containers in parallel this way with independently initialized database.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6867:
[AIRFLOW-6315] Create .airflow_db_initialised always in tests dir
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6867: [AIRFLOW-6315] Create .airflow_db_initialised always in tests dir
URL: https://github.com/apache/airflow/pull/6867#issuecomment-568268141
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=h1) Report
> Merging [#6867](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/65ef8f3f810d90efa1d868f0bda460c0d13321f2?src=pr&el=desc) will **decrease** coverage by `0.23%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6867 +/- ##
==========================================
- Coverage 84.56% 84.33% -0.24%
==========================================
Files 680 680
Lines 38454 38501 +47
==========================================
- Hits 32520 32468 -52
- Misses 5934 6033 +99
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/settings.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXR0aW5ncy5weQ==) | `93.66% <0%> (-0.05%)` | :arrow_down: |
| [airflow/example\_dags/tutorial.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvdHV0b3JpYWwucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_compute.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfY29tcHV0ZS5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_compute\_hook.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9jb21wdXRlX2hvb2sucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/utils/dates.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYXRlcy5weQ==) | `89.36% <0%> (ø)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=footer). Last update [65ef8f3...081bced](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6867:
[AIRFLOW-6315] Create .airflow_db_initialised always in tests dir
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6867: [AIRFLOW-6315] Create .airflow_db_initialised always in tests dir
URL: https://github.com/apache/airflow/pull/6867#issuecomment-568268141
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=h1) Report
> Merging [#6867](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/65ef8f3f810d90efa1d868f0bda460c0d13321f2?src=pr&el=desc) will **decrease** coverage by `0.23%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6867 +/- ##
==========================================
- Coverage 84.56% 84.33% -0.24%
==========================================
Files 680 680
Lines 38454 38501 +47
==========================================
- Hits 32520 32468 -52
- Misses 5934 6033 +99
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/settings.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXR0aW5ncy5weQ==) | `93.66% <0%> (-0.05%)` | :arrow_down: |
| [airflow/example\_dags/tutorial.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvdHV0b3JpYWwucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_compute.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfY29tcHV0ZS5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_compute\_hook.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9jb21wdXRlX2hvb2sucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/utils/dates.py](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYXRlcy5weQ==) | `89.36% <0%> (ø)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/airflow/pull/6867/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=footer). Last update [65ef8f3...081bced](https://codecov.io/gh/apache/airflow/pull/6867?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #6867: [AIRFLOW-6315] Create
.airflow_db_initialised always in tests dir
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #6867: [AIRFLOW-6315] Create .airflow_db_initialised always in tests dir
URL: https://github.com/apache/airflow/pull/6867#issuecomment-567945542
After reboot breeze, shouldn't the database be initialized again? I think so because we have a ephemeral environment. All data except the source code and files directory is lost after reboot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #6867: [AIRFLOW-6315] Create
.airflow_db_initialised always in tests dir
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #6867: [AIRFLOW-6315] Create .airflow_db_initialised always in tests dir
URL: https://github.com/apache/airflow/pull/6867#issuecomment-568268833
Finally ! Good to go. Do the honors @nuclearpinguin :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] nuclearpinguin commented on issue #6867: [AIRFLOW-6315]
Create .airflow_db_initialised always in tests dir
Posted by GitBox <gi...@apache.org>.
nuclearpinguin commented on issue #6867: [AIRFLOW-6315] Create .airflow_db_initialised always in tests dir
URL: https://github.com/apache/airflow/pull/6867#issuecomment-567950632
Good catch @mik-laj ! Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services