You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/08/16 10:47:27 UTC

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #7974: ARROW-9756: [Rust] [DataFusion] Added support for scalar UDFs of arbitrary return types

jorgecarleitao commented on a change in pull request #7974:
URL: https://github.com/apache/arrow/pull/7974#discussion_r471097047



##########
File path: rust/datafusion/src/logicalplan.rs
##########
@@ -1087,7 +1101,7 @@ impl LogicalPlanBuilder {
     /// Apply a projection
     pub fn project(&self, expr: Vec<Expr>) -> Result<Self> {
         let input_schema = self.plan.schema();
-        let projected_expr = if expr.contains(&Expr::Wildcard) {

Review comment:
       I had to drop partialEq for expressions, and therefore also dropped this if that was strictly not needed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org