You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/04/30 11:24:03 UTC
[GitHub] [solr-site] cpoerschke opened a new pull request #19: remove lucene-solr repo transition period mention on community.md
cpoerschke opened a new pull request #19:
URL: https://github.com/apache/solr-site/pull/19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-site] cpoerschke commented on a change in pull request #19: remove lucene-solr repo transition period mention on community.md
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on a change in pull request #19:
URL: https://github.com/apache/solr-site/pull/19#discussion_r623805910
##########
File path: content/pages/community.md
##########
@@ -122,8 +122,6 @@ can be obtained from [git-scm.com](https://git-scm.com/). There are also GIT int
IDEs. For Eclipse, look at [EGit](http://www.eclipse.org/egit/). IntelliJ has git support bundled, if you
have installed the command line version.
-> **NOTE:** We are in a transition period where Solr code still lives in <https://github.com/apache/lucene-solr>, but will soon move to the new Solr repository.
Review comment:
Or I see that `apache/solr` repo is already mentioned at line 127/129 below, perhaps we could reword here somehow w.r.t. `apache/lucene-solr` being for `branch_8x` etc. still but that might be confusing with development typically being against `main` branch and perhaps the _"branch_8x in lucene-solr repo"_ stuff is already covered elsewhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-site] janhoy commented on a change in pull request #19: remove lucene-solr repo transition period mention on community.md
Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #19:
URL: https://github.com/apache/solr-site/pull/19#discussion_r626401345
##########
File path: content/pages/community.md
##########
@@ -122,8 +122,6 @@ can be obtained from [git-scm.com](https://git-scm.com/). There are also GIT int
IDEs. For Eclipse, look at [EGit](http://www.eclipse.org/egit/). IntelliJ has git support bundled, if you
have installed the command line version.
-> **NOTE:** We are in a transition period where Solr code still lives in <https://github.com/apache/lucene-solr>, but will soon move to the new Solr repository.
Review comment:
+1 to a re-wording that new development happens in solr repo, but you may still occationally need to backport a fix to lucene-solr repo's branch_8x or branch_8_8 branches. You can also link to https://github.com/apache/lucene-solr README that also has some wording about this. I don't know if a link to https://github.com/apache/lucene-solr/blob/master/PRs.md is relevant here as a temporary note until 9.0 is released?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-site] janhoy commented on pull request #19: remove lucene-solr repo transition period mention on community.md
Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #19:
URL: https://github.com/apache/solr-site/pull/19#issuecomment-842994552
Please feel free to merge this PR as is. The NOTE is wrong as it stands now. 90% of development will happen against the new repo, so folks can worry about backporting later...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org