[GitHub] [spark] NarekDW commented on a diff in pull request #39501: [SPARK-41295][SQL] Rename the error classes

[GitBox <gi...@apache.org>]

NarekDW commented on code in PR #39501:
URL: https://github.com/apache/spark/pull/39501#discussion_r1066785694


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeExtractors.scala:
##########
@@ -64,7 +64,7 @@ object ExtractValue {
 
       case (_: ArrayType, _) => GetArrayItem(child, extraction)
 
-      case (MapType(kt, _, _), _) => GetMapValue(child, extraction)
+      case (MapType(_, _, _), _) => GetMapValue(child, extraction)

Review Comment:
   Are you asking about this particular line of code or the whole change? 
   If about the change itself - then at least it improves code readability IMHO



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org